Merge pull request #2617 from ruby-grape/migrate-to-dry-configurable

Migrate from ActiveSupport::Configurable to Dry::Configurable

Author: dblock

CHANGELOG.md

@@ -21,8 +21,9 @@
 * [#2605](https://github.com/ruby-grape/grape/pull/2605): Add Rack 3.2 support with new gemfile and CI integration - [@ericproulx](https://github.com/ericproulx).
 * [#2607](https://github.com/ruby-grape/grape/pull/2607): Remove namespace_stackable and namespace_inheritable from public API - [@ericproulx](https://github.com/ericproulx).
 * [#2615](https://github.com/ruby-grape/grape/pull/2615): Remove manual toc and tod danger check - [@alexanderadam](https://github.com/alexanderadam).
-* Your contribution here.
 * [#2612](https://github.com/ruby-grape/grape/pull/2612): Avoid multiple mount pollution - [@alexanderadam](https://github.com/alexanderadam).
+* [#2617](https://github.com/ruby-grape/grape/pull/2617): Migrate from `ActiveSupport::Configurable` to `Dry::Configurable` - [@ericproulx](https://github.com/ericproulx).
+* Your contribution here.
 
 #### Fixes
 

UPGRADING.md

@@ -3,7 +3,13 @@ Upgrading Grape
 
 ### Upgrading to >= 3.0.0
 
-### Endpoint execution simplified and `return` deprecated
+#### Configuration API Migration from ActiveSupport::Configurable to Dry::Configurable
+
+Grape has migrated from `ActiveSupport::Configurable` to `Dry::Configurable` for its configuration system since its [deprecated](https://github.com/rails/rails/blob/1cdd190a25e483b65f1f25bbd0f13a25d696b461/activesupport/lib/active_support/configurable.rb#L3-L7).
+
+See [#2617](https://github.com/ruby-grape/grape/pull/2617) for more information.
+
+#### Endpoint execution simplified and `return` deprecated
 
 Executing a endpoint's block has been simplified and calling `return` in it has been deprecated.
 

grape.gemspec

@@ -22,6 +22,7 @@ Gem::Specification.new do |s|
   }
 
   s.add_dependency 'activesupport', '>= 7.0'
+  s.add_dependency 'dry-configurable'
   s.add_dependency 'dry-types', '>= 1.1'
   s.add_dependency 'mustermann-grape', '~> 1.1.0'
   s.add_dependency 'rack', '>= 2'

lib/grape.rb

@@ -3,7 +3,6 @@
 require 'logger'
 require 'active_support'
 require 'active_support/concern'
-require 'active_support/configurable'
 require 'active_support/version'
 require 'active_support/isolated_execution_state'
 require 'active_support/core_ext/array/conversions'
@@ -28,6 +27,7 @@
 require 'active_support/inflector'
 require 'active_support/ordered_options'
 require 'active_support/notifications'
+require 'dry-configurable'
 
 require 'English'
 require 'bigdecimal'
@@ -57,7 +57,10 @@
 I18n.load_path << File.expand_path('grape/locale/en.yml', __dir__)
 
 module Grape
-  include ActiveSupport::Configurable
+  extend Dry::Configurable
+
+  setting :param_builder, default: :hash_with_indifferent_access
+  setting :lint, default: false
 
   HTTP_SUPPORTED_METHODS = [
     Rack::GET,
@@ -72,12 +75,6 @@ module Grape
   def self.deprecator
     @deprecator ||= ActiveSupport::Deprecation.new('2.0', 'Grape')
   end
-
-  configure do |config|
-    config.param_builder = :hash_with_indifferent_access
-    config.lint = false
-    config.compile_methods!
-  end
 end
 
 # https://api.rubyonrails.org/classes/ActiveSupport/Deprecation.html