Skip to content

Commit 13b03ba

Browse files
authored
Merge pull request #789 from junaruga/wip/remove-ed25519-fips-not-approved
Remove test_ed25519_not_approved_on_fips.
2 parents 3fc8972 + d43904b commit 13b03ba

File tree

1 file changed

+0
-26
lines changed

1 file changed

+0
-26
lines changed

test/openssl/test_pkey.rb

Lines changed: 0 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -150,32 +150,6 @@ def test_ed25519
150150
assert_raise(OpenSSL::PKey::PKeyError) { priv.derive(pub) }
151151
end
152152

153-
def test_ed25519_not_approved_on_fips
154-
omit_on_non_fips
155-
# Ed25519 is technically allowed in the OpenSSL 3.0 code as a kind of bug.
156-
# So, we need to omit OpenSSL 3.0.
157-
#
158-
# See OpenSSL providers/fips/fipsprov.c PROV_NAMES_ED25519 entries with
159-
# FIPS_DEFAULT_PROPERTIES on openssl-3.0 branch and
160-
# FIPS_UNAPPROVED_PROPERTIES on openssl-3.1 branch.
161-
#
162-
# See also
163-
# https://github.com/openssl/openssl/issues/20758#issuecomment-1639658102
164-
# for details.
165-
unless openssl?(3, 1, 0, 0)
166-
omit 'Ed25519 is allowed in the OpenSSL 3.0 FIPS code as a kind of bug'
167-
end
168-
169-
priv_pem = <<~EOF
170-
-----BEGIN PRIVATE KEY-----
171-
MC4CAQAwBQYDK2VwBCIEIEzNCJso/5banbbDRuwRTg9bijGfNaumJNqM9u1PuKb7
172-
-----END PRIVATE KEY-----
173-
EOF
174-
assert_raise(OpenSSL::PKey::PKeyError) do
175-
OpenSSL::PKey.read(priv_pem)
176-
end
177-
end
178-
179153
def test_x25519
180154
# Test vector from RFC 7748 Section 6.1
181155
alice_pem = <<~EOF

0 commit comments

Comments
 (0)