From 1715e97f1b1db631cac7b83682d484d34df1baef Mon Sep 17 00:00:00 2001 From: Olof Skyttner Date: Fri, 17 Jan 2025 07:28:01 +0100 Subject: [PATCH 1/4] Added assert to testcase --- test/test_core.rb | 1 + 1 file changed, 1 insertion(+) diff --git a/test/test_core.rb b/test/test_core.rb index 48666c86..34fe9e07 100644 --- a/test/test_core.rb +++ b/test/test_core.rb @@ -882,6 +882,7 @@ def test_attlist_decl ]> EOL + assert_equal '', doc.doctype.children[0].to_s.gsub(/\s+/, " ") assert_equal 'gobble', doc.root.attributes['bar'] assert_equal 'xxx', doc.root.elements[2].namespace assert_equal 'two', doc.root.elements[1].namespace From 560c94d82b228fc36c5c1227c68c451e979a02b5 Mon Sep 17 00:00:00 2001 From: Olof Skyttner Date: Fri, 17 Jan 2025 07:28:14 +0100 Subject: [PATCH 2/4] Fixed serialization of ATTLIST --- lib/rexml/parsers/baseparser.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/rexml/parsers/baseparser.rb b/lib/rexml/parsers/baseparser.rb index 13cdd821..87f50f09 100644 --- a/lib/rexml/parsers/baseparser.rb +++ b/lib/rexml/parsers/baseparser.rb @@ -378,7 +378,7 @@ def pull_event md = @source.match(Private::ATTLISTDECL_END, true) raise REXML::ParseException.new( "Bad ATTLIST declaration!", @source ) if md.nil? element = md[1] - contents = md[0] + contents = " Date: Fri, 17 Jan 2025 13:25:06 +0100 Subject: [PATCH 3/4] Added rdoc as a development dependency (for Ruby 3.5+) --- Gemfile | 1 + 1 file changed, 1 insertion(+) diff --git a/Gemfile b/Gemfile index 1710ec99..d323e2c5 100644 --- a/Gemfile +++ b/Gemfile @@ -16,6 +16,7 @@ group :development do # depends on "ostruct" explicitly. gem "ostruct" gem "rake" + gem "rdoc" end group :benchmark do From f6ea424705825140e170b1608ef6b93df4ff502b Mon Sep 17 00:00:00 2001 From: Olof Skyttner Date: Mon, 20 Jan 2025 06:55:09 +0100 Subject: [PATCH 4/4] Revert "Added rdoc as a development dependency (for Ruby 3.5+)" This reverts commit 4de910f954863944afc0ed106f21f9e68e8abebc. --- Gemfile | 1 - 1 file changed, 1 deletion(-) diff --git a/Gemfile b/Gemfile index d323e2c5..1710ec99 100644 --- a/Gemfile +++ b/Gemfile @@ -16,7 +16,6 @@ group :development do # depends on "ostruct" explicitly. gem "ostruct" gem "rake" - gem "rdoc" end group :benchmark do