Move base_name and other_names extraction into build_output_text

Author: rafaelfranca

lib/benchmark_runner.rb

@@ -48,7 +48,9 @@ def write_csv(output_path, ruby_descriptions, table)
     end
 
     # Build output text string with metadata, table, and legend
-    def build_output_text(ruby_descriptions, table, format, bench_failures, base_name, other_names)
+    def build_output_text(ruby_descriptions, table, format, bench_failures)
+      base_name, *other_names = ruby_descriptions.keys
+
       output_str = +""
 
       ruby_descriptions.each do |key, value|

run_benchmarks.rb

@@ -57,7 +57,6 @@
 
 # Build results table
 all_names = args.executables.keys
-base_name, *other_names = all_names
 builder = ResultsTableBuilder.new(
   executable_names: all_names,
   bench_data: bench_data,
@@ -76,7 +75,7 @@
 BenchmarkRunner.write_csv(output_path, ruby_descriptions, table)
 
 # Save the output in a text file that we can easily refer to
-output_str = BenchmarkRunner.build_output_text(ruby_descriptions, table, format, bench_failures, base_name, other_names)
+output_str = BenchmarkRunner.build_output_text(ruby_descriptions, table, format, bench_failures)
 out_txt_path = output_path + ".txt"
 File.open(out_txt_path, "w") { |f| f.write output_str }
 

test/benchmark_runner_test.rb

@@ -377,11 +377,9 @@
       ]
       format = ['%s', '%.1f', '%.1f', '%.1f', '%.1f']
       bench_failures = {}
-      base_name = 'ruby-base'
-      other_names = ['ruby-yjit']
 
       result = BenchmarkRunner.build_output_text(
-        ruby_descriptions, table, format, bench_failures, base_name, other_names
+        ruby_descriptions, table, format, bench_failures
       )
 
       assert_includes result, 'ruby-base: ruby 3.3.0'
@@ -399,11 +397,9 @@
       ]
       format = ['%s', '%.1f', '%.1f']
       bench_failures = {}
-      base_name = 'ruby'
-      other_names = []
 
       result = BenchmarkRunner.build_output_text(
-        ruby_descriptions, table, format, bench_failures, base_name, other_names
+        ruby_descriptions, table, format, bench_failures
       )
 
       # Should contain table headers
@@ -419,11 +415,9 @@
       table = [['bench', 'ruby (ms)'], ['fib', '100.0']]
       format = ['%s', '%.1f']
       bench_failures = {}
-      base_name = 'ruby'
-      other_names = []
 
       result = BenchmarkRunner.build_output_text(
-        ruby_descriptions, table, format, bench_failures, base_name, other_names
+        ruby_descriptions, table, format, bench_failures
       )
 
       refute_includes result, 'Legend:'
@@ -438,11 +432,9 @@
       table = [['bench', 'ruby (ms)', 'ruby-yjit (ms)', 'ruby-rjit (ms)']]
       format = ['%s', '%.1f', '%.1f', '%.1f']
       bench_failures = {}
-      base_name = 'ruby'
-      other_names = ['ruby-yjit', 'ruby-rjit']
 
       result = BenchmarkRunner.build_output_text(
-        ruby_descriptions, table, format, bench_failures, base_name, other_names
+        ruby_descriptions, table, format, bench_failures
       )
 
       assert_includes result, 'ruby-yjit 1st itr'
@@ -458,11 +450,9 @@
       bench_failures = {
         'ruby' => { 'failed_bench' => 'error message' }
       }
-      base_name = 'ruby'
-      other_names = []
 
       result = BenchmarkRunner.build_output_text(
-        ruby_descriptions, table, format, bench_failures, base_name, other_names
+        ruby_descriptions, table, format, bench_failures
       )
 
       # TableFormatter handles displaying failures, just verify it's called
@@ -475,11 +465,9 @@
       table = [['bench']]
       format = ['%s']
       bench_failures = {}
-      base_name = 'ruby'
-      other_names = []
 
       result = BenchmarkRunner.build_output_text(
-        ruby_descriptions, table, format, bench_failures, base_name, other_names
+        ruby_descriptions, table, format, bench_failures
       )
 
       assert_kind_of String, result
@@ -495,11 +483,9 @@
       table = [['bench']]
       format = ['%s']
       bench_failures = {}
-      base_name = 'ruby-a'
-      other_names = []
 
       result = BenchmarkRunner.build_output_text(
-        ruby_descriptions, table, format, bench_failures, base_name, other_names
+        ruby_descriptions, table, format, bench_failures
       )
 
       lines = result.lines