Assert on HTML in order to wait the action response

Assering only on DB record value would randomly fail.

Author: amatsuda

app/views/staff/program_sessions/_session_row_active.html.haml

@@ -1,4 +1,4 @@
-%tr{ data: { 'emails' => speakers_emails(program_session) } }
+%tr{ id: dom_id(program_session.object), data: { 'emails' => speakers_emails(program_session) } }
   %td= link_to(program_session.title,
       event_staff_program_session_path(program_session.event, program_session))
   %td= program_session.speakers.map { |speaker| link_to speaker.name, event_staff_program_speaker_path(program_session.event, speaker) }.join(", ").html_safe

spec/system/staff/organizer_manages_program_session_spec.rb

@@ -18,11 +18,18 @@
 
     scenario "from program session index", js: true do
       visit event_staff_program_sessions_path(event)
+      within("##{ActionView::RecordIdentifier.dom_id(waitlisted_session)}") do
+        expect(page).to have_content ProgramSession::CONFIRMED_WAITLISTED.upcase
+      end
+
       page.accept_confirm do
         page.find('#waitlist').click
         find('tr', text: waitlisted_session.title).click_link("Promote")
       end
 
+      within("##{ActionView::RecordIdentifier.dom_id(waitlisted_session)}") do
+        expect(page).to have_content ProgramSession::LIVE.upcase
+      end
       expect(page).to_not have_css(".alert-danger")
       expect(waitlisted_session.reload.state).to eq(ProgramSession::LIVE)
     end
@@ -46,10 +53,17 @@
 
     scenario "from program session index", js: true do
       visit event_staff_program_sessions_path(event)
+      within("##{ActionView::RecordIdentifier.dom_id(draft_session)}") do
+        expect(page).to have_content ProgramSession::DRAFT.upcase
+      end
+
       page.accept_confirm do
         find('tr', text: draft_session.title).click_link("Promote")
       end
 
+      within("##{ActionView::RecordIdentifier.dom_id(draft_session)}") do
+        expect(page).to have_content ProgramSession::LIVE.upcase
+      end
       expect(page).to_not have_css(".alert-danger")
       expect(draft_session.reload.state).to eq(ProgramSession::LIVE)
     end