Manual/Auto Declaration

[DH-Deployment]

Hi team,

First of all, huge fan, you guys have saved me countless hours with this library. I've integrated it into my framework, been using it for a few months now and it's flawless. Unsung heroes. Please provide a donation/sponsor link I'd like to buy you all a beer or 12.

I've got a bit of a query/concern if someone could be so kind:

I noticed that by default every Order plant request provides "MANUAL" as the manual_or_auto OrderPlacement type, i.e in submit_order():

manual_or_auto=pb.request_new_order_pb2.RequestNewOrder.OrderPlacement.MANUAL

I've heard that Rithmic/CME can be quite ruthless about ensuring these are accurately reported when submitting orders. Whether they were submitted by an automated system or by a human clicking the buy/sell button.

I just wanted to hear your thoughts/experience on this, if I should be concerned that I haven't changed it to AUTO till now? If I should just leave it as it is? Or if I should overwrite all the sections in which MANUAL is stated, with AUTO? And if so, could you be so kind and confirm that this in fact the correct protocol_buffer definition:

manual_or_auto=pb.request_new_order_pb2.RequestNewOrder.OrderPlacement.AUTO

I kind of just guessed/deduced from the /protocol_buffers/request_new_order_pb2.py, but those protocol_buffers and Rithmic documentations are super confusing and not fully conclusive that it would just be as simple as AUTO instead of MANUAL.

Thanks in advance for any help!
All the best

[rundef]

Thanks for the kind words !

You're right manual_or_auto should be flexible. The current behavior is just leftover from the original pyrithmic fork.

I will publish a new release during the week to fix it, will keep you posted

[DH-Deployment]

Thanks for getting back to me @rundef 🙏 and you're most welcome, they are well deserved!

I've opened PR #41 for your review. First ever public contribution, I will take no offence if you throw it right in the bin

Cheers again

[rundef]

You can use v1.5.7 which contain your changes from PR #41

Thanks again for the contribution !