fix(general): use constant 2^31 limit for better readability

Author: fayzanx

src/decoder.test.ts

@@ -379,9 +379,11 @@ describe('lib/decoder', () => {
       return Buffer.concat([padding, header, contentBuf]);
     }
 
+    const MAX_INT_32 = 2147483648;
+
     it('should handle string just below 2^31 boundary', function () {
       this.timeout(15000);
-      const offset = 0x7ffffff0; // 2^31 - 16
+      const offset = MAX_INT_32 - 16;
       const content = 'boundary test';
 
       const buffer = createBufferWithStringAtOffset(offset, content);
@@ -398,7 +400,7 @@ describe('lib/decoder', () => {
 
     it('should handle when string at offset >= 2^31', function () {
       this.timeout(15000);
-      const offset = 0x80000000; // Exactly 2^31
+      const offset = MAX_INT_32;
       const content = 'test';
 
       const buffer = createBufferWithStringAtOffset(offset, content);

src/decoder.ts

@@ -6,6 +6,8 @@ utils.assert(
   'Apparently you are using old version of node. Please upgrade to node 10.4.x or above.'
 );
 
+const MAX_INT_32 = 2_147_483_647;
+
 enum DataType {
   Extended = 0,
   Pointer = 1,
@@ -282,7 +284,7 @@ export default class Decoder {
 
   private decodeString(offset: number, size: number) {
     const newOffset = offset + size;
-    return newOffset >= 2147483648 // 2^31 Buffer.toString() limit
+    return newOffset >= MAX_INT_32
       ? this.db.subarray(offset, newOffset).toString('utf8')
       : this.db.toString('utf8', offset, newOffset);
   }