Skip to content

Conversation

@jan4843
Copy link

@jan4843 jan4843 commented Jun 24, 2020

Requests where the body is not valid JSON would cause MultiJson::ParseError to be raised but not translated to a RequestHandler error. Handling RequestHandler::ExternalBaseError should arguably include parsing errors caused by invalid user input.

@codecov-commenter
Copy link

codecov-commenter commented Jun 25, 2020

Codecov Report

Merging #47 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #47   +/-   ##
=======================================
  Coverage   98.19%   98.20%           
=======================================
  Files          41       41           
  Lines         887      889    +2     
=======================================
+ Hits          871      873    +2     
  Misses         16       16           
Impacted Files Coverage Δ
lib/request_handler/body_parser.rb 100.00% <100.00%> (ø)
lib/request_handler/error.rb 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80a6d77...ab80ff4. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants