Lint files (#77)

dkcumming · web-flow · commit 32f80f7a9f0b · 2025-10-31T16:01:46.000Z
We haven't been running the linter, this PR is the application of clippy and fmt via `pnpm p-token:lint`. Changes have not been propagated to `program` (spl token) yet @Stevengre we might need to work together to achieve that. I have run these concrete tests: - `pnpm p-token:build` - `pnpm p-token:test` - `pnpm programs:test:pinocchio:rv` I have run these proofs (chosen as they pass and after not too long): - [x] test_process_approve - [x] test_process_approve_checked - [x] test_process_transfer - [x] test_process_mint_to - [x] test_process_burn - [x] test_process_close_account - [x] test_process_transfer_checked - [x] test_process_burn_checked - [x] test_process_revoke - [x] test_process_freeze_account - [x] test_process_thaw_account - [x] test_process_mint_to_checked - [x] test_process_sync_native - [x] test_process_get_account_data_size - [x] test_process_initialize_immutable_owner NOTE: I saw flakeyness on `test_process_sync_native` getting and Kore RPC error `RuntimeError: Empty response received` - I have since run the proof under the same conditions again and it is passing, I am not sure if it was my local environment but I will record this here.
diff --git a/p-token/src/entrypoint-runtime-verification.rs b/p-token/src/entrypoint-runtime-verification.rs
diff --git a/p-token/tests/approve.rs b/p-token/tests/approve.rs
@@ -85,7 +85,7 @@ async fn approve() {
 }
 
 // #[tokio::test]
-async fn approve_invalid_src() {
+async fn _approve_invalid_src() {
     let mut context = ProgramTest::new("pinocchio_token_program", TOKEN_PROGRAM_ID, None)
         .start_with_context()
         .await;
diff --git a/p-token/tests/approve_checked.rs b/p-token/tests/approve_checked.rs
@@ -87,7 +87,7 @@ async fn approve_checked() {
 }
 
 // #[tokio::test]
-async fn approve_checked_invalid_src() {
+async fn _approve_checked_invalid_src() {
     let mut context = ProgramTest::new("pinocchio_token_program", TOKEN_PROGRAM_ID, None)
         .start_with_context()
         .await;
diff --git a/p-token/tests/burn.rs b/p-token/tests/burn.rs
@@ -75,7 +75,7 @@ async fn burn() {
 }
 
 // #[tokio::test]
-async fn burn_invalid_source() {
+async fn _burn_invalid_source() {
     let mut context = ProgramTest::new("pinocchio_token_program", TOKEN_PROGRAM_ID, None)
         .start_with_context()
         .await;
diff --git a/p-token/tests/burn_checked.rs b/p-token/tests/burn_checked.rs
@@ -82,7 +82,7 @@ async fn burn_checked() {
 }
 
 // #[tokio::test]
-async fn burn_checked_invalid_source() {
+async fn _burn_checked_invalid_source() {
     let mut context = ProgramTest::new("pinocchio_token_program", TOKEN_PROGRAM_ID, None)
         .start_with_context()
         .await;
diff --git a/p-token/tests/close_account.rs b/p-token/tests/close_account.rs
@@ -117,7 +117,7 @@ async fn close_same_accounts() {
 }
 
 // #[tokio::test]
-async fn close_invalid_source() {
+async fn _close_invalid_source() {
     let mut context = ProgramTest::new("pinocchio_token_program", TOKEN_PROGRAM_ID, None)
         .start_with_context()
         .await;
diff --git a/p-token/tests/freeze_account.rs b/p-token/tests/freeze_account.rs
@@ -72,7 +72,7 @@ async fn freeze_account() {
 }
 
 // #[tokio::test]
-async fn freeze_account_invalid_source() {
+async fn _freeze_account_invalid_source() {
     let mut context = ProgramTest::new("pinocchio_token_program", TOKEN_PROGRAM_ID, None)
         .start_with_context()
         .await;
diff --git a/p-token/tests/initialize_multisig.rs b/p-token/tests/initialize_multisig.rs
@@ -76,7 +76,7 @@ async fn initialize_multisig() {
 }
 
 // #[tokio::test]
-async fn initialize_multisig_invalid_multisig() {
+async fn _initialize_multisig_invalid_multisig() {
     let context = ProgramTest::new("pinocchio_token_program", TOKEN_PROGRAM_ID, None)
         .start_with_context()
         .await;
diff --git a/p-token/tests/initialize_multisig2.rs b/p-token/tests/initialize_multisig2.rs
@@ -76,7 +76,7 @@ async fn initialize_multisig2() {
 }
 
 // #[tokio::test]
-async fn initialize_multisig2_invalid_multisig() {
+async fn _initialize_multisig2_invalid_multisig() {
     let context = ProgramTest::new("pinocchio_token_program", TOKEN_PROGRAM_ID, None)
         .start_with_context()
         .await;
diff --git a/p-token/tests/mint_to.rs b/p-token/tests/mint_to.rs
@@ -70,7 +70,7 @@ async fn mint_to() {
 }
 
 // #[tokio::test]
-async fn mint_to_invalid_destination() {
+async fn _mint_to_invalid_destination() {
     let mut context = ProgramTest::new("pinocchio_token_program", TOKEN_PROGRAM_ID, None)
         .start_with_context()
         .await;
diff --git a/p-token/tests/mint_to_checked.rs b/p-token/tests/mint_to_checked.rs
@@ -71,7 +71,7 @@ async fn mint_to_checked() {
 }
 
 // #[tokio::test]
-async fn mint_to_checked_invalid_destination() {
+async fn _mint_to_checked_invalid_destination() {
     let mut context = ProgramTest::new("pinocchio_token_program", TOKEN_PROGRAM_ID, None)
         .start_with_context()
         .await;
diff --git a/p-token/tests/revoke.rs b/p-token/tests/revoke.rs
@@ -89,7 +89,7 @@ async fn revoke() {
 }
 
 // #[tokio::test]
-async fn revoke_invalid_source() {
+async fn _revoke_invalid_source() {
     let mut context = ProgramTest::new("pinocchio_token_program", TOKEN_PROGRAM_ID, None)
         .start_with_context()
         .await;
diff --git a/p-token/tests/set_authority.rs b/p-token/tests/set_authority.rs
@@ -67,7 +67,7 @@ async fn set_authority() {
 }
 
 // #[tokio::test]
-async fn set_authority_invalid_account() {
+async fn _set_authority_invalid_account() {
     let mut context = ProgramTest::new("pinocchio_token_program", TOKEN_PROGRAM_ID, None)
         .start_with_context()
         .await;
diff --git a/p-token/tests/thaw_account.rs b/p-token/tests/thaw_account.rs
@@ -81,7 +81,7 @@ async fn thaw_account() {
 }
 
 // #[tokio::test]
-async fn thaw_account_invalid_src() {
+async fn _thaw_account_invalid_src() {
     let mut context = ProgramTest::new("pinocchio_token_program", TOKEN_PROGRAM_ID, None)
         .start_with_context()
         .await;
diff --git a/p-token/tests/transfer.rs b/p-token/tests/transfer.rs
@@ -86,7 +86,7 @@ async fn transfer() {
 }
 
 // #[tokio::test]
-async fn transfer_src_uninit() {
+async fn _transfer_src_uninit() {
     let mut context = ProgramTest::new("pinocchio_token_program", TOKEN_PROGRAM_ID, None)
         .start_with_context()
         .await;
@@ -152,7 +152,7 @@ async fn transfer_src_uninit() {
 }
 
 // #[tokio::test]
-async fn transfer_dst_uninit() {
+async fn _transfer_dst_uninit() {
     let mut context = ProgramTest::new("pinocchio_token_program", TOKEN_PROGRAM_ID, None)
         .start_with_context()
         .await;
diff --git a/p-token/tests/transfer_checked.rs b/p-token/tests/transfer_checked.rs
@@ -89,7 +89,7 @@ async fn transfer_checked() {
 
 
 // #[tokio::test]
-async fn transfer_checked_src_uninit() {
+async fn _transfer_checked_src_uninit() {
     let mut context = ProgramTest::new("pinocchio_token_program", TOKEN_PROGRAM_ID, None)
         .start_with_context()
         .await;
@@ -157,7 +157,7 @@ async fn transfer_checked_src_uninit() {
 }
 
 // #[tokio::test]
-async fn transfer_checked_dst_uninit() {
+async fn _transfer_checked_dst_uninit() {
     let mut context = ProgramTest::new("pinocchio_token_program", TOKEN_PROGRAM_ID, None)
         .start_with_context()
         .await;

Original file line number	Diff line number	Diff line change
`@@ -85,7 +85,7 @@ async fn approve() {`
`85`	`85`	`}`
`86`	`86`
`87`	`87`	`// #[tokio::test]`
`88`		`-async fn approve_invalid_src() {`
	`88`	`+async fn _approve_invalid_src() {`
`89`	`89`	`let mut context = ProgramTest::new("pinocchio_token_program", TOKEN_PROGRAM_ID, None)`
`90`	`90`	`.start_with_context()`
`91`	`91`	`.await;`
Original file line number	Diff line number	Diff line change
`@@ -87,7 +87,7 @@ async fn approve_checked() {`
`87`	`87`	`}`
`88`	`88`
`89`	`89`	`// #[tokio::test]`
`90`		`-async fn approve_checked_invalid_src() {`
	`90`	`+async fn _approve_checked_invalid_src() {`
`91`	`91`	`let mut context = ProgramTest::new("pinocchio_token_program", TOKEN_PROGRAM_ID, None)`
`92`	`92`	`.start_with_context()`
`93`	`93`	`.await;`
Original file line number	Diff line number	Diff line change
`@@ -75,7 +75,7 @@ async fn burn() {`
`75`	`75`	`}`
`76`	`76`
`77`	`77`	`// #[tokio::test]`
`78`		`-async fn burn_invalid_source() {`
	`78`	`+async fn _burn_invalid_source() {`
`79`	`79`	`let mut context = ProgramTest::new("pinocchio_token_program", TOKEN_PROGRAM_ID, None)`
`80`	`80`	`.start_with_context()`
`81`	`81`	`.await;`
Original file line number	Diff line number	Diff line change
`@@ -82,7 +82,7 @@ async fn burn_checked() {`
`82`	`82`	`}`
`83`	`83`
`84`	`84`	`// #[tokio::test]`
`85`		`-async fn burn_checked_invalid_source() {`
	`85`	`+async fn _burn_checked_invalid_source() {`
`86`	`86`	`let mut context = ProgramTest::new("pinocchio_token_program", TOKEN_PROGRAM_ID, None)`
`87`	`87`	`.start_with_context()`
`88`	`88`	`.await;`
Original file line number	Diff line number	Diff line change
`@@ -117,7 +117,7 @@ async fn close_same_accounts() {`
`117`	`117`	`}`
`118`	`118`
`119`	`119`	`// #[tokio::test]`
`120`		`-async fn close_invalid_source() {`
	`120`	`+async fn _close_invalid_source() {`
`121`	`121`	`let mut context = ProgramTest::new("pinocchio_token_program", TOKEN_PROGRAM_ID, None)`
`122`	`122`	`.start_with_context()`
`123`	`123`	`.await;`
Original file line number	Diff line number	Diff line change
`@@ -72,7 +72,7 @@ async fn freeze_account() {`
`72`	`72`	`}`
`73`	`73`
`74`	`74`	`// #[tokio::test]`
`75`		`-async fn freeze_account_invalid_source() {`
	`75`	`+async fn _freeze_account_invalid_source() {`
`76`	`76`	`let mut context = ProgramTest::new("pinocchio_token_program", TOKEN_PROGRAM_ID, None)`
`77`	`77`	`.start_with_context()`
`78`	`78`	`.await;`
Original file line number	Diff line number	Diff line change
`@@ -76,7 +76,7 @@ async fn initialize_multisig() {`
`76`	`76`	`}`
`77`	`77`
`78`	`78`	`// #[tokio::test]`
`79`		`-async fn initialize_multisig_invalid_multisig() {`
	`79`	`+async fn _initialize_multisig_invalid_multisig() {`
`80`	`80`	`let context = ProgramTest::new("pinocchio_token_program", TOKEN_PROGRAM_ID, None)`
`81`	`81`	`.start_with_context()`
`82`	`82`	`.await;`
Original file line number	Diff line number	Diff line change
`@@ -70,7 +70,7 @@ async fn mint_to() {`
`70`	`70`	`}`
`71`	`71`
`72`	`72`	`// #[tokio::test]`
`73`		`-async fn mint_to_invalid_destination() {`
	`73`	`+async fn _mint_to_invalid_destination() {`
`74`	`74`	`let mut context = ProgramTest::new("pinocchio_token_program", TOKEN_PROGRAM_ID, None)`
`75`	`75`	`.start_with_context()`
`76`	`76`	`.await;`