impl Drop for async File & Volume with embassy_futures::block_on

Author: Be-ing

Cargo.toml

@@ -17,6 +17,7 @@ rust-version = "1.76"
 bisync = "0.3.0"
 byteorder = {version = "1", default-features = false}
 defmt = {version = "0.3", optional = true}
+embassy-futures = "0.1.1"
 embedded-hal = "1.0.0"
 embedded-hal-async = "1.0.0"
 embedded-io = "0.6.1"

src/inner/filesystem/files.rs

@@ -1,4 +1,4 @@
-use super::super::super::{bisync, only_sync};
+use super::super::super::{bisync, only_sync, only_async};
 use super::super::super::{ErrorType, Read, Seek, SeekFrom, Write};
 use super::super::{
     filesystem::{ClusterId, DirEntry, Handle},
@@ -49,8 +49,10 @@ impl RawFile {
 /// error that may occur will be ignored. To handle potential errors, use
 /// the [`File::close`] method.
 ///
-/// For async Files, async drop does not exist in Rust, so you *must* call
-/// [`File::close`] when you are done with a File.
+/// For async `Files`, the implementation of [`Drop`] blocks with [`embassy_futures::block_on`]
+/// because there is no way to `.await` inside [`Drop::drop`]. If you would prefer
+/// to rely on the async executor you are already using, call [`File::close`]
+/// manually instead of letting the `File` drop.
 pub struct File<'a, D, T, const MAX_DIRS: usize, const MAX_FILES: usize, const MAX_VOLUMES: usize>
 where
     D: BlockDevice,
@@ -150,7 +152,6 @@ where
     }
 }
 
-// async drop does not yet exist :(
 #[only_sync]
 impl<'a, D, T, const MAX_DIRS: usize, const MAX_FILES: usize, const MAX_VOLUMES: usize> Drop
     for File<'a, D, T, MAX_DIRS, MAX_FILES, MAX_VOLUMES>
@@ -163,6 +164,18 @@ where
     }
 }
 
+#[only_async]
+impl<'a, D, T, const MAX_DIRS: usize, const MAX_FILES: usize, const MAX_VOLUMES: usize> Drop
+    for File<'a, D, T, MAX_DIRS, MAX_FILES, MAX_VOLUMES>
+where
+    D: BlockDevice,
+    T: TimeSource,
+{
+    fn drop(&mut self) {
+        _ = embassy_futures::block_on(self.volume_mgr.close_file(self.raw_file));
+    }
+}
+
 impl<'a, D, T, const MAX_DIRS: usize, const MAX_FILES: usize, const MAX_VOLUMES: usize>
     core::fmt::Debug for File<'a, D, T, MAX_DIRS, MAX_FILES, MAX_VOLUMES>
 where

src/inner/mod.rs

@@ -19,7 +19,7 @@ use core::fmt::Debug;
 use embedded_io::ErrorKind;
 use filesystem::Handle;
 
-use super::{bisync, only_sync};
+use super::{bisync, only_sync, only_async};
 
 #[doc(inline)]
 pub use blockdevice::{Block, BlockCache, BlockCount, BlockDevice, BlockIdx};
@@ -210,8 +210,10 @@ impl RawVolume {
 /// any error that may occur will be ignored. To handle potential errors, use
 /// the [`Volume::close`] method.
 ///
-/// For async Volumes, async drop does not exist in Rust, so you *must* call
-/// [`Volume::close`] when you are done with a Volume.
+/// For async `Volumes`, the implementation of [`Drop`] blocks with [`embassy_futures::block_on`]
+/// because there is no way to `.await` inside [`Drop::drop`]. If you would prefer
+/// to rely on the async executor you are already using, call [`Volume::close`]
+/// manually instead of letting the `Volume` drop.
 pub struct Volume<'a, D, T, const MAX_DIRS: usize, const MAX_FILES: usize, const MAX_VOLUMES: usize>
 where
     D: BlockDevice,
@@ -268,7 +270,6 @@ where
     }
 }
 
-// async drop does not yet exist :(
 #[only_sync]
 impl<'a, D, T, const MAX_DIRS: usize, const MAX_FILES: usize, const MAX_VOLUMES: usize> Drop
     for Volume<'a, D, T, MAX_DIRS, MAX_FILES, MAX_VOLUMES>
@@ -281,6 +282,18 @@ where
     }
 }
 
+#[only_async]
+impl<'a, D, T, const MAX_DIRS: usize, const MAX_FILES: usize, const MAX_VOLUMES: usize> Drop
+    for Volume<'a, D, T, MAX_DIRS, MAX_FILES, MAX_VOLUMES>
+where
+    D: BlockDevice,
+    T: TimeSource,
+{
+    fn drop(&mut self) {
+        _ = embassy_futures::block_on(self.volume_mgr.close_volume(self.raw_volume));
+    }
+}
+
 impl<'a, D, T, const MAX_DIRS: usize, const MAX_FILES: usize, const MAX_VOLUMES: usize>
     core::fmt::Debug for Volume<'a, D, T, MAX_DIRS, MAX_FILES, MAX_VOLUMES>
 where