Merge #57

57: Add `no-semihosting` feature to suppress all semihosting calls r=adamgreig a=nickray

I must not be the only one who indulges in semihosting for quick print-debugging and then has a trail of intermediate mess...

With this new feature, one can easily patch out all these calls in the application (by additivity of cargo features), and get a binary that runs without debugger attached.

Co-authored-by: Nicolas Stalder <n@stalder.io>

Author: bors[bot]

Cargo.toml

@@ -16,6 +16,7 @@ edition = "2018"
 [features]
 inline-asm = []
 jlink-quirks = []
+no-semihosting = []
 
 [dependencies]
 cortex-m = ">= 0.5.8, < 0.7"

src/lib.rs

@@ -170,6 +170,10 @@
 //! latest version 6.48b of J-Link exhibits such behaviour, causing a panic if this feature
 //! is not enabled.
 //!
+//! ## `no-semihosting`
+//!
+//! When this feature is enabled, the underlying system calls to `bkpt` are patched out.
+//!
 //! # Reference
 //!
 //! For documentation about the semihosting operations, check:
@@ -207,16 +211,21 @@ pub unsafe fn syscall<T>(nr: usize, arg: &T) -> usize {
 #[inline(always)]
 pub unsafe fn syscall1(_nr: usize, _arg: usize) -> usize {
     match () {
-        #[cfg(all(thumb, not(feature = "inline-asm")))]
+        #[cfg(all(thumb, not(feature = "inline-asm"), not(feature = "no-semihosting")))]
         () => __syscall(_nr, _arg),
 
-        #[cfg(all(thumb, feature = "inline-asm"))]
+        #[cfg(all(thumb, feature = "inline-asm", not(feature = "no-semihosting")))]
         () => {
             let mut nr = _nr;
             llvm_asm!("bkpt 0xAB" : "+{r0}"(nr) : "{r1}"(_arg) :: "volatile");
             nr
         }
 
+        #[cfg(all(thumb, feature = "no-semihosting"))]
+        () => {
+            0
+        }
+
         #[cfg(not(thumb))]
         () => unimplemented!(),
     }