Merge pull request #503 from YuhanLiin/indexmap-partialeq

Relax indexmap PartialEq bounds so value doesn't need to be Eq

Author: reitermarkus

CHANGELOG.md

@@ -58,6 +58,8 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 - Changed `stable_deref_trait` to a platform-dependent dependency.
 - Changed `SortedLinkedList::pop` return type from `Result<T, ()>` to `Option<T>` to match `std::vec::pop`.
 - `Vec::capacity` is no longer a `const` function.
+- Relaxed bounds on `PartialEq` for `IndexMap` from `V: Eq` to `V1: PartialEq<V2>`.
+- Relaxed bounds on `PartialEq` for `LinearMap` from `V: PartialEq` to `V1: PartialEq<V2>`.
 
 ### Fixed
 

src/indexmap.rs

@@ -1276,15 +1276,15 @@ where
     }
 }
 
-impl<K, V, S, S2, const N: usize, const N2: usize> PartialEq<IndexMap<K, V, S2, N2>>
-    for IndexMap<K, V, S, N>
+impl<K, V1, V2, S1, S2, const N1: usize, const N2: usize> PartialEq<IndexMap<K, V2, S2, N2>>
+    for IndexMap<K, V1, S1, N1>
 where
     K: Eq + Hash,
-    V: Eq,
-    S: BuildHasher,
+    V1: PartialEq<V2>,
+    S1: BuildHasher,
     S2: BuildHasher,
 {
-    fn eq(&self, other: &IndexMap<K, V, S2, N2>) -> bool {
+    fn eq(&self, other: &IndexMap<K, V2, S2, N2>) -> bool {
         self.len() == other.len()
             && self
                 .iter()
@@ -1879,4 +1879,11 @@ mod tests {
             assert_eq!(value, i + 1);
         }
     }
+
+    #[test]
+    fn partial_eq_floats() {
+        // Make sure `PartialEq` is implemented even if `V` doesn't implement `Eq`.
+        let map: FnvIndexMap<usize, f32, 4> = Default::default();
+        assert_eq!(map, map);
+    }
 }

src/linear_map.rs

@@ -614,13 +614,13 @@ impl<'a, K, V> Iterator for IterMut<'a, K, V> {
     }
 }
 
-impl<K, V, S1: LinearMapStorage<K, V> + ?Sized, S2: LinearMapStorage<K, V> + ?Sized>
-    PartialEq<LinearMapInner<K, V, S2>> for LinearMapInner<K, V, S1>
+impl<K, V1, V2, S1: LinearMapStorage<K, V1> + ?Sized, S2: LinearMapStorage<K, V2> + ?Sized>
+    PartialEq<LinearMapInner<K, V2, S2>> for LinearMapInner<K, V1, S1>
 where
     K: Eq,
-    V: PartialEq,
+    V1: PartialEq<V2>,
 {
-    fn eq(&self, other: &LinearMapInner<K, V, S2>) -> bool {
+    fn eq(&self, other: &LinearMapInner<K, V2, S2>) -> bool {
         self.len() == other.len()
             && self
                 .iter()
@@ -745,4 +745,11 @@ mod test {
     ) -> &'c LinearMapView<&'b (), u32> {
         x
     }
+
+    #[test]
+    fn partial_eq_floats() {
+        // Make sure `PartialEq` is implemented even if `V` doesn't implement `Eq`.
+        let map: LinearMap<usize, f32, 4> = Default::default();
+        assert_eq!(map, map);
+    }
 }