feat: emit help messages for github pull request url in dependency #16207
+146
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
motorailgun
force-pushed
the
git-pr-url
branch
3 times, most recently
from
3a91b48 to
87f00a3
Compare
Contributor
|
As a heads up, we have some helpful suggestions for PRs at our contrib guide, including
|
Contributor
|
Ah, the title says this is for an error but the code looks to be related to a warning |
epage
reviewed
Nov 5, 2025
epage
reviewed
Nov 5, 2025
motorailgun
changed the title
motorailgun
changed the title
motorailgun
force-pushed
the
git-pr-url
branch
2 times, most recently
from
69d5d4f to
d771595
Compare
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 6, 2025
### What does this PR try to resolve? Explicitly call out that we use rustc's diagnostic style guide, e.g. #16207 (comment) ### How to test and review this PR?
motorailgun
force-pushed
the
git-pr-url
branch
2 times, most recently
from
55fb6f2 to
f2836a7
Compare
Contributor
Author
|
Just have pushed changes reflecting kind reviews. The commit history is kind of a mess, so I'll clean it out once the change is confirmed appropriate. I'd also like to work on this but I think that should be another PR. |
rustbot
added
the
S-waiting-on-review
Collaborator
|
r? @weihanglo rustbot has assigned @weihanglo. Use |
motorailgun
force-pushed
the
git-pr-url
branch
from
f2836a7 to
8e8755c
Compare
weihanglo
reviewed
Nov 9, 2025
| " `git = \"{}\" rev = \"{}\"` \n", | ||
| " to specify pull requests as dependencies' revision." | ||
| ), | ||
| url, repo_url, rev |
Member
There was a problem hiding this comment.
nit: prefer inline arg like git = "{repo_url}"
Contributor
Author
There was a problem hiding this comment.
Agreed, but format! does not capture variables when the format string is expanded from a macro (in this case, concat!). I'd prefer readability of concat! over iteration of push_string(format!(...)) s.
motorailgun
force-pushed
the
git-pr-url
branch
from
250f935 to
2bf6886
Compare
Collaborator
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
motorailgun
changed the title
motorailgun
force-pushed
the
git-pr-url
branch
from
2bf6886 to
a9b8e6d
Compare
Contributor
Author
|
Cleared out commits, rebased on latest master. Also edited PR comment to reflect current implementation. |
epage
reviewed
Nov 10, 2025
epage
reviewed
Nov 10, 2025
epage
reviewed
Nov 10, 2025
motorailgun
force-pushed
the
git-pr-url
branch
from
a9b8e6d to
7cfe468
Compare
Contributor
Author
|
Wasn't aware of these, thanks! |
epage
reviewed
Nov 10, 2025
motorailgun
force-pushed
the
git-pr-url
branch
from
7cfe468 to
ca2973a
Compare
epage
approved these changes
Nov 10, 2025
rustbot
removed
the
S-waiting-on-review
bors
added a commit
to rust-lang/rust
that referenced
this pull request
Nov 12, 2025
Update cargo 10 commits in 445fe4a68f469bf936b2fd81de2c503b233a7f4f..2d4fa139552ebdd5f091a1401ed03f7dc62cb43f 2025-11-07 18:08:19 +0000 to 2025-11-12 15:56:06 +0000 - feat: Add unstable rustc-unicode flag (rust-lang/cargo#16243) - fix(package): all tar entries timestamp be the same (rust-lang/cargo#16242) - feat: emit help messages for github pull request url in dependency (rust-lang/cargo#16207) - docs: fix comments for alternative registry fns (rust-lang/cargo#16235) - add into_value utility function for inheritableField (rust-lang/cargo#16234) - fix(command-vendor): strip_prefix panic in cp_sources method (rust-lang/cargo#16214) - fix(lock): Be moore direct in the error message (rust-lang/cargo#16233) - fix(lock): In error, differentiate between creating and updating lockfile (rust-lang/cargo#16227) - fix(cli): Refer to commands, not subcommands (rust-lang/cargo#16226) - fix(run): Help teach about argument escaping (rust-lang/cargo#16225)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Succeeding #15003.
Piror to this, using a GitHub pull request URLs as dependencies would just fail because of HTTP errors as it's simply not a git repository. This PR implements some help messages on such cases for users to know why it's failing, and how to fix it.
Close #15001.