Skip to content

Remove no-op unversioned-shared-resources CLI #2956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 28, 2025
Merged

Remove no-op unversioned-shared-resources CLI #2956

merged 1 commit into from
Oct 28, 2025

Conversation

@notriddle
Copy link
Contributor

@notriddle notriddle commented Oct 28, 2025

@notriddle notriddle requested a review from a team as a code owner October 28, 2025 00:30
@github-actions github-actions bot added the S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed label Oct 28, 2025
syphar
syphar approved these changes Oct 28, 2025
View reviewed changes
Copy link
Member

@syphar syphar left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make sense.

Just for my information:
since when (roughly) is this argument no-op?

@syphar syphar merged commit eafb285 into rust-lang:master Oct 28, 2025
10 of 11 checks passed
@github-actions github-actions bot added S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it and removed S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed labels Oct 28, 2025
@notriddle notriddle deleted the unversioned-shared-resources branch October 28, 2025 16:10
@notriddle
Copy link
Contributor Author

notriddle commented Oct 28, 2025

It became a no-op in rust-lang/rust@f9e1f6f

@syphar
Copy link
Member

syphar commented Oct 28, 2025

oh, that's a long time ago :)

Thanks for the cleanup!

@syphar syphar removed the S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it label Oct 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@syphar syphar syphar approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@notriddle @syphar