epoll_event cannot carry provenance on user data

[RalfJung]

The epoll_event type is declared like this in C:

       struct epoll_event {
           uint32_t      events;  /* Epoll events */
           epoll_data_t  data;    /* User data variable */
       };

       union epoll_data {
           void     *ptr;
           int       fd;
           uint32_t  u32;
           uint64_t  u64;
       };

       typedef union epoll_data  epoll_data_t;

However, the Rust version in libc is different -- it just uses u64 for the data field. That is, unfortunately, not equivalent -- u64 cannot carry pointer provenance, so programs that want to store a pointer in data (which is quite common) need to use exposed-provenance APIs (i.e., ptr/int casts). Tokio carries some funky hacks to avoid that.

Since the C API is actually compatible with strict provenance here, it would be nice to expose that in libc as well. Given this is a breaking change it can only happen for libc 1.0 -- though it would be possible to have a separate event_data type and event_ctl declaration in its own module even in libc 0.2.

[RalfJung]

Looks like in fact for 1.0 this has already been fixed

libc/src/unix/linux_like/mod.rs

Lines 334 to 344 in 72a590f

	pub struct epoll_event {
	pub events: u32,
	pub data: epoll_data,
	}
	pub union epoll_data {
	pub ptr: *mut c_void,
	pub fd: c_int,
	pub u32: u32,
	pub u64: u64,
	}