report everything as an error for crater

Author: petrochenkov

compiler/rustc_resolve/src/build_reduced_graph.rs

@@ -83,12 +83,13 @@ impl<'ra, 'tcx> Resolver<'ra, 'tcx> {
         span: Span,
         expansion: LocalExpnId,
         ambiguity: Option<(NameBinding<'ra>, AmbiguityKind)>,
-        warn_ambiguity: bool,
+        _warn_ambiguity: bool,
     ) {
         let binding = self.arenas.alloc_name_binding(NameBindingData {
             kind: NameBindingKind::Res(res),
             ambiguity,
-            warn_ambiguity,
+            // FIXME: report everything as an error for crater
+            warn_ambiguity: false,
             vis,
             span,
             expansion,

tests/ui/imports/ambiguous-2.rs

@@ -5,5 +5,4 @@ extern crate ambiguous_1;
 
 fn main() {
     ambiguous_1::id(); //~ ERROR `id` is ambiguous
-                       //~| WARN this was previously accepted
 }

tests/ui/imports/ambiguous-2.stderr

@@ -1,11 +1,9 @@
-error: `id` is ambiguous
+error[E0659]: `id` is ambiguous
   --> $DIR/ambiguous-2.rs:7:18
    |
 LL |     ambiguous_1::id();
    |                  ^^ ambiguous name
    |
-   = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
-   = note: for more information, see issue #114095 <https://github.com/rust-lang/rust/issues/114095>
    = note: ambiguous because of multiple glob imports of a name in the same module
 note: `id` could refer to the function defined here
   --> $DIR/auxiliary/../ambiguous-1.rs:13:13
@@ -17,29 +15,7 @@ note: `id` could also refer to the function defined here
    |
 LL |     pub use self::handwritten::*;
    |             ^^^^^^^^^^^^^^^^^
-   = note: `#[deny(ambiguous_glob_imports)]` (part of `#[deny(future_incompatible)]`) on by default
 
 error: aborting due to 1 previous error
 
-Future incompatibility report: Future breakage diagnostic:
-error: `id` is ambiguous
-  --> $DIR/ambiguous-2.rs:7:18
-   |
-LL |     ambiguous_1::id();
-   |                  ^^ ambiguous name
-   |
-   = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
-   = note: for more information, see issue #114095 <https://github.com/rust-lang/rust/issues/114095>
-   = note: ambiguous because of multiple glob imports of a name in the same module
-note: `id` could refer to the function defined here
-  --> $DIR/auxiliary/../ambiguous-1.rs:13:13
-   |
-LL |     pub use self::evp::*;
-   |             ^^^^^^^^^
-note: `id` could also refer to the function defined here
-  --> $DIR/auxiliary/../ambiguous-1.rs:15:13
-   |
-LL |     pub use self::handwritten::*;
-   |             ^^^^^^^^^^^^^^^^^
-   = note: `#[deny(ambiguous_glob_imports)]` (part of `#[deny(future_incompatible)]`) on by default
-
+For more information about this error, try `rustc --explain E0659`.

tests/ui/imports/ambiguous-4.rs

@@ -4,5 +4,4 @@ extern crate ambiguous_4_extern;
 
 fn main() {
     ambiguous_4_extern::id(); //~ ERROR `id` is ambiguous
-                              //~| WARN this was previously accepted
 }

tests/ui/imports/ambiguous-4.stderr

@@ -1,11 +1,9 @@
-error: `id` is ambiguous
+error[E0659]: `id` is ambiguous
   --> $DIR/ambiguous-4.rs:6:25
    |
 LL |     ambiguous_4_extern::id();
    |                         ^^ ambiguous name
    |
-   = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
-   = note: for more information, see issue #114095 <https://github.com/rust-lang/rust/issues/114095>
    = note: ambiguous because of multiple glob imports of a name in the same module
 note: `id` could refer to the function defined here
   --> $DIR/auxiliary/../ambiguous-4-extern.rs:12:9
@@ -17,29 +15,7 @@ note: `id` could also refer to the function defined here
    |
 LL | pub use handwritten::*;
    |         ^^^^^^^^^^^
-   = note: `#[deny(ambiguous_glob_imports)]` (part of `#[deny(future_incompatible)]`) on by default
 
 error: aborting due to 1 previous error
 
-Future incompatibility report: Future breakage diagnostic:
-error: `id` is ambiguous
-  --> $DIR/ambiguous-4.rs:6:25
-   |
-LL |     ambiguous_4_extern::id();
-   |                         ^^ ambiguous name
-   |
-   = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
-   = note: for more information, see issue #114095 <https://github.com/rust-lang/rust/issues/114095>
-   = note: ambiguous because of multiple glob imports of a name in the same module
-note: `id` could refer to the function defined here
-  --> $DIR/auxiliary/../ambiguous-4-extern.rs:12:9
-   |
-LL | pub use evp::*;
-   |         ^^^
-note: `id` could also refer to the function defined here
-  --> $DIR/auxiliary/../ambiguous-4-extern.rs:13:9
-   |
-LL | pub use handwritten::*;
-   |         ^^^^^^^^^^^
-   = note: `#[deny(ambiguous_glob_imports)]` (part of `#[deny(future_incompatible)]`) on by default
-
+For more information about this error, try `rustc --explain E0659`.