-
Notifications
You must be signed in to change notification settings - Fork 13.6k
Open
Labels
C-enhancementCategory: An issue proposing an enhancement or a PR with one.Category: An issue proposing an enhancement or a PR with one.T-infraRelevant to the infrastructure team, which will review and decide on the PR/issue.Relevant to the infrastructure team, which will review and decide on the PR/issue.
Description
Rustbot currently posts a warning on any PR that modifies Cargo.lock
. this is helpful in cases where Cargo.lock
was modified accidentally, for example if cargo ran with an old version of a submodule checked out. However, many PRs change Cargo.lock
intentionally and shouldn't get the warning. As a heuristic, we can use "did any Cargo.toml
change": if so, it's very likely the change was intentional.
@compiler-errors says this may be tricky since triage bot currently doesn't support conditional pings on files.
cc @BoxyUwU, I think you added this warning originally.
Originally posted by @rustbot in #103993 (comment)
Metadata
Metadata
Assignees
Labels
C-enhancementCategory: An issue proposing an enhancement or a PR with one.Category: An issue proposing an enhancement or a PR with one.T-infraRelevant to the infrastructure team, which will review and decide on the PR/issue.Relevant to the infrastructure team, which will review and decide on the PR/issue.