-
Notifications
You must be signed in to change notification settings - Fork 13.6k
Closed
Labels
A-run-makeArea: port run-make Makefiles to rmake.rsArea: port run-make Makefiles to rmake.rsA-testsuiteArea: The testsuite used to check the correctness of rustcArea: The testsuite used to check the correctness of rustcC-cleanupCategory: PRs that clean code up or issues documenting cleanup.Category: PRs that clean code up or issues documenting cleanup.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.Relevant to the compiler team, which will review and decide on the PR/issue.
Description
Noticed in #125683 (comment), we should add helpers for:
- fs operation wrappers that panic on failure and provide good context to aid debugging
- e.g. wrap
std::fs::remove_file(path)
withrun_make_support::fs::remove_file(path)
but on panic shows thepath
we're trying to remove, so the test writer doesn't forget to check the result of fs operations.
- e.g. wrap
cc @Oneirical in case you want to work on this.
UPDATE: we reworked rmake.rs tests to not run in the test sources directory so tmp_dir().join()
is no longer relevant.
Oneirical
Metadata
Metadata
Assignees
Labels
A-run-makeArea: port run-make Makefiles to rmake.rsArea: port run-make Makefiles to rmake.rsA-testsuiteArea: The testsuite used to check the correctness of rustcArea: The testsuite used to check the correctness of rustcC-cleanupCategory: PRs that clean code up or issues documenting cleanup.Category: PRs that clean code up or issues documenting cleanup.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.Relevant to the compiler team, which will review and decide on the PR/issue.