-
Notifications
You must be signed in to change notification settings - Fork 13.9k
Description
This is a tracking issue for work on pin ergonomics.
The feature gate for the issue is #![feature(pin_ergonomics)].
Design sketch
The basic pin projection rules that we're working toward are:
Alternative B:
- If
T: Unpin,&pin mut Tand&mut Tcoerce to each other. - If a
struct,enum, orunion(?) defining a typeTis annotated with#[pin_v2](todo bikeshedding), then:- Projection of
&pin mut Tto&pin mut T.Uis allowed. - If
T: Drop, theDropimpl must usefn drop(&pin mut self). - No manual impls of
Unpinare allowed onT. - The user must ensure that, given a pinned reference to
T, the pinning contract is upheld for all?Unpinfields ofT.
- Projection of
(The rules apply likewise for &pin const T.)
Beyond pin projection, the basic overall idea of pin ergonomics is that &pin mut T (and &pin const T) should be integrated in the same sense as &mut T, in that reborrowing works, autoref works, corresponding binding modes exist, and that the borrow checker will track and ensure that once a &pin mut T is taken (even if no longer live) that we can't later get a &mut T or move T.
Alternative A
The original proposal, now labeled Alternative A, was:
- If
T: Unpin,&pin mut Tand&mut Tcoerce to each other. - If
T: Drop + !Unpin, require theDropimpl forTto usefn drop(&pin mut self). - Projection of
&pin mut Tto&pin mut T.Uis allowed if eitherT: !UnpinorU: Unpin.
These rules are factored differently (using coercions (see here) and the fact that we haven't stabilized negative impls yet), but have the same effect as the rules in Niko's otherwise similar MinPin proposal.
About tracking issues
Tracking issues are used to record the overall progress of implementation. They are also used as hubs connecting to other relevant issues, e.g., bugs or open design questions. A tracking issue is however not meant for large scale discussion, questions, or bug reports about a feature. Instead, open a dedicated issue for the specific matter and add the relevant feature gate label.
Steps
- Approve as lang experiment.
- We accepted this experiment in the 2024-09-18 lang triage meeting.
- Accept an RFC.
- Implement pin reborrowing in nightly.
- Implement pin autoref in nightly.
- Implement
&pin const/&pin mutconstructor syntax in nightly. - Implement
&pin const/&pin muttype syntax in nightly. - Implement
&pin const self/&pin mut selfargument syntax in nightly. - Implement pin projection in pattern matching in nightly.
- Implement
fn drop(&pin mut self). - Require
fn drop(&pin mut self)whenT: Drop + !Unpin. - Implement coercions between
&pin (mut|const) Tand&(mut) TwhenT: Unpin. - Add
ForceUnpin<T>type. - Investigate affordances for unsafe parts of the
PinAPI. - Add documentation to the dev guide.
- See the instructions.
- Add documentation to the reference.
- See the instructions.
- Add formatting for new syntax to the style guide.
- See the nightly style procedure.
- Stabilize.
- See the instructions.
Unresolved Questions
TODO.
Related
TODO.
cc @eholk @rust-lang/lang
Sub-issues
Metadata
Metadata
Assignees
Labels
Type
Projects
Status