-
Notifications
You must be signed in to change notification settings - Fork 13.6k
Closed
Labels
A-bootstrap-stampArea: bootstrap stamp logicArea: bootstrap stamp logicC-cleanupCategory: PRs that clean code up or issues documenting cleanup.Category: PRs that clean code up or issues documenting cleanup.E-needs-investigationCall for partcipation: This issues needs some investigation to determine current statusCall for partcipation: This issues needs some investigation to determine current statusT-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Description
We were looking to revisit the tool_check_step!
macro in check logic in #134950, but found that stamp logic was scattered. Different check steps (and probably other step kinds) might not have their stamp logic be consistently handled if only one stamp logic site is changed but not the others.
Change of stamp looks sus: the same stamps build in
too, but now they desync. I think it's simpler to revert it in current pr (and optionally rework stamps in separate pr, so they can be produces somehow centralized).
.join(format!(".{}-check.stamp", stringify!($name).to_lowercase()));
Originally posted by @klensy in #134950 (comment)
Might be valuable to double-check how stamps are handled throughout bootstrap, and possibly unify the stamp handling logic so they don't risk diverging.
Metadata
Metadata
Assignees
Labels
A-bootstrap-stampArea: bootstrap stamp logicArea: bootstrap stamp logicC-cleanupCategory: PRs that clean code up or issues documenting cleanup.Category: PRs that clean code up or issues documenting cleanup.E-needs-investigationCall for partcipation: This issues needs some investigation to determine current statusCall for partcipation: This issues needs some investigation to determine current statusT-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)