Skip to content

Commit 15bf1ac

Browse files
committed
crc32: remove #[cfg(not(target_arch = "arm"))] from crc functions
They are defined in the aarch64 module, so this cfg is pointless. Note that these instructions do exist for arm, but the aarch64 ones are already stable, so this would need some additional work to implement them for arm.
1 parent 9f12c1a commit 15bf1ac

File tree

2 files changed

+0
-8
lines changed

2 files changed

+0
-8
lines changed

crates/core_arch/src/aarch64/neon/generated.rs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@ use super::*;
1616
#[doc = "[Arm's documentation](https://developer.arm.com/architectures/instruction-sets/intrinsics/__crc32cd)"]
1717
#[inline]
1818
#[target_feature(enable = "crc")]
19-
#[cfg(not(target_arch = "arm"))]
2019
#[cfg_attr(test, assert_instr(crc32cx))]
2120
#[stable(feature = "stdarch_aarch64_crc32", since = "1.80.0")]
2221
pub fn __crc32cd(crc: u32, data: u64) -> u32 {
@@ -33,7 +32,6 @@ pub fn __crc32cd(crc: u32, data: u64) -> u32 {
3332
#[doc = "[Arm's documentation](https://developer.arm.com/architectures/instruction-sets/intrinsics/__crc32d)"]
3433
#[inline]
3534
#[target_feature(enable = "crc")]
36-
#[cfg(not(target_arch = "arm"))]
3735
#[cfg_attr(test, assert_instr(crc32x))]
3836
#[stable(feature = "stdarch_aarch64_crc32", since = "1.80.0")]
3937
pub fn __crc32d(crc: u32, data: u64) -> u32 {

crates/stdarch-gen-arm/spec/neon/aarch64.spec.yml

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -13,10 +13,6 @@ auto_llvm_sign_conversion: false
1313
neon-stable: &neon-stable
1414
FnCall: [stable, ['feature = "neon_intrinsics"', 'since = "1.59.0"']]
1515

16-
# #[cfg(not(target_arch = "arm"))]
17-
target-not-arm: &target-not-arm
18-
FnCall: [cfg, [{ FnCall: [not, ['target_arch = "arm"']]}]]
19-
2016
# #[cfg(not(target_arch = "arm64ec"))]
2117
target-not-arm64ec: &target-not-arm64ec
2218
FnCall: [cfg, [{ FnCall: [not, ['target_arch = "arm64ec"']]}]]
@@ -13082,7 +13078,6 @@ intrinsics:
1308213078
return_type: "{type[0]}"
1308313079
attr:
1308413080
- FnCall: [target_feature, ['enable = "crc"']]
13085-
- *target-not-arm
1308613081
- FnCall: [cfg_attr, [test, { FnCall: [assert_instr, ["crc32x"]] }]]
1308713082
- *aarch64-crc-stable
1308813083
safety: safe
@@ -13104,7 +13099,6 @@ intrinsics:
1310413099
return_type: "{type[0]}"
1310513100
attr:
1310613101
- FnCall: [target_feature, ['enable = "crc"']]
13107-
- *target-not-arm
1310813102
- FnCall: [cfg_attr, [test, { FnCall: [assert_instr, ["crc32cx"]] }]]
1310913103
- *aarch64-crc-stable
1311013104
safety: safe

0 commit comments

Comments
 (0)