chore: add check duplicate to the team members

Author: vivekjami

src/validate.rs

@@ -220,35 +220,37 @@ fn validate_team_leads(data: &Data, errors: &mut Vec<String>) {
     });
 }
 
-/// Ensure team members are people and don't contain duplicates
+/// Ensure team members are unique and exist
 fn validate_team_members(data: &Data, errors: &mut Vec<String>) {
     wrapper(data.teams(), errors, |team, errors| {
-        let mut seen = std::collections::HashSet::new();
-        wrapper(team.members(data)?.iter(), errors, |member, _| {
-            // Check if member exists
-            if data.person(member).is_none() {
+        // Check for duplicate members in explicit_members
+        let mut seen = HashSet::new();
+        for member in team.explicit_members() {
+            if !seen.insert(&member.github) {
                 bail!(
-                    "person {} is member of team {} but doesn't exist",
-                    member,
+                    "person `{}` is duplicated in team `{}`",
+                    member.github,
                     team.name()
                 );
             }
+        }
 
-            // Check for duplicates
-            if !seen.insert(member) {
+        // Ensure members are real people
+        wrapper(team.members(data)?.iter(), errors, |member, _| {
+            if data.person(member).is_none() {
                 bail!(
-                    "person {} is listed multiple times in team {}",
+                    "person `{}` is member of team `{}` but doesn't exist",
                     member,
                     team.name()
                 );
             }
-
             Ok(())
         });
         Ok(())
     });
 }
 
+
 /// Alumni team must consist only of automatically populated alumni from the other teams
 fn validate_alumni(data: &Data, errors: &mut Vec<String>) {
     let Some(alumni_team) = data.team("alumni") else {

tests/bless.sh

@@ -1,12 +1,12 @@
-#!/bin/bash
-
-set -euo pipefail
-IFS=$'\n\t'
-
-cd "$(dirname "$0")"
-if [[ -d static-api/_output ]]; then
-    rm -rf static-api/_expected
-    cp -r static-api/_output static-api/_expected
-else
-    echo "didn't bless static-api as there is no output to bless"
-fi
+#!/bin/bash
+
+set -euo pipefail
+IFS=$'\n\t'
+
+cd "$(dirname "$0")"
+if [[ -d static-api/_output ]]; then
+    rm -rf static-api/_expected
+    cp -r static-api/_output static-api/_expected
+else
+    echo "didn't bless static-api as there is no output to bless"
+fi