Skip to content

Commit cb1f225

Browse files
committed
Respect dry run and add logs
1 parent c5797d3 commit cb1f225

File tree

1 file changed

+23
-13
lines changed

1 file changed

+23
-13
lines changed

sync-team/src/crates_io/api.rs

Lines changed: 23 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -85,19 +85,23 @@ impl CratesIoApi {
8585
krate: &str,
8686
owners: &[CratesIoOwner],
8787
) -> anyhow::Result<()> {
88+
debug!("Inviting owners {owners:?} to crate {krate}");
89+
8890
#[derive(serde::Serialize)]
8991
struct InviteOwnersRequest<'a> {
9092
owners: Vec<&'a str>,
9193
}
9294

9395
let owners = owners.iter().map(|o| o.login.as_str()).collect::<Vec<_>>();
9496

95-
self.req(
96-
reqwest::Method::PUT,
97-
&format!("/crates/{krate}/owners"),
98-
Some(&InviteOwnersRequest { owners }),
99-
)?
100-
.error_for_status()?;
97+
if !self.dry_run {
98+
self.req(
99+
reqwest::Method::PUT,
100+
&format!("/crates/{krate}/owners"),
101+
Some(&InviteOwnersRequest { owners }),
102+
)?
103+
.error_for_status()?;
104+
}
101105

102106
Ok(())
103107
}
@@ -108,20 +112,26 @@ impl CratesIoApi {
108112
krate: &str,
109113
owners: &[CratesIoOwner],
110114
) -> anyhow::Result<()> {
115+
debug!("Deleting owners {owners:?} from crate {krate}");
116+
111117
#[derive(serde::Serialize)]
112118
struct DeleteOwnersRequest<'a> {
113119
owners: &'a [&'a str],
114120
}
115121

116122
let owners = owners.iter().map(|o| o.login.as_str()).collect::<Vec<_>>();
117123

118-
self.req(
119-
reqwest::Method::DELETE,
120-
&format!("/crates/{krate}/owners"),
121-
Some(&DeleteOwnersRequest { owners: &owners }),
122-
)?
123-
.error_for_status()
124-
.with_context(|| anyhow::anyhow!("Cannot delete owner(s) {owners:?} from krate {krate}"))?;
124+
if !self.dry_run {
125+
self.req(
126+
reqwest::Method::DELETE,
127+
&format!("/crates/{krate}/owners"),
128+
Some(&DeleteOwnersRequest { owners: &owners }),
129+
)?
130+
.error_for_status()
131+
.with_context(|| {
132+
anyhow::anyhow!("Cannot delete owner(s) {owners:?} from krate {krate}")
133+
})?;
134+
}
125135

126136
Ok(())
127137
}

0 commit comments

Comments
 (0)