Fix all warnings for now

Author: IsaacWoods

src/address.rs

@@ -129,6 +129,11 @@ impl<H> MappedGas<H>
 where
     H: Handler,
 {
+    /// Map the given `GenericAddress`, giving a `MappedGas` that can be read from and written to.
+    ///
+    /// ### Safety
+    /// The supplied `GenericAddress` must be a valid GAS and all subsequent reads and writes must
+    /// be valid.
     pub unsafe fn map_gas(gas: GenericAddress, handler: &H) -> Result<MappedGas<H>, AcpiError> {
         match gas.address_space {
             AddressSpace::SystemMemory => {
@@ -183,7 +188,7 @@ where
                 let mapping = self.mapping.as_ref().unwrap();
                 match access_size_bits {
                     8 => unsafe {
-                        core::ptr::write_volatile(mapping.virtual_start.as_ptr() as *mut u8, value as u8);
+                        core::ptr::write_volatile(mapping.virtual_start.as_ptr(), value as u8);
                     },
                     16 => unsafe {
                         core::ptr::write_volatile(mapping.virtual_start.as_ptr() as *mut u16, value as u16);

src/aml/mod.rs

@@ -737,7 +737,7 @@ where
                     }
                     Opcode::Acquire => {
                         let [Argument::Object(mutex)] = &op.arguments[..] else { panic!() };
-                        let Object::Mutex { mutex, sync_level } = **mutex else {
+                        let Object::Mutex { mutex, sync_level: _ } = **mutex else {
                             Err(AmlError::InvalidOperationOnObject { op: Operation::Acquire, typ: mutex.typ() })?
                         };
                         let timeout = context.next_u16()?;
@@ -753,7 +753,7 @@ where
                     }
                     Opcode::Release => {
                         let [Argument::Object(mutex)] = &op.arguments[..] else { panic!() };
-                        let Object::Mutex { mutex, sync_level } = **mutex else {
+                        let Object::Mutex { mutex, sync_level: _ } = **mutex else {
                             Err(AmlError::InvalidOperationOnObject { op: Operation::Release, typ: mutex.typ() })?
                         };
 
@@ -1348,7 +1348,7 @@ where
                     let behaviour = if context.current_block.kind == BlockKind::Package {
                         ResolveBehaviour::PackageElement
                     } else if context.current_block.kind == BlockKind::VarPackage {
-                        if context.last_op()?.arguments.len() == 0 {
+                        if context.last_op()?.arguments.is_empty() {
                             ResolveBehaviour::ResolveToObject
                         } else {
                             ResolveBehaviour::PackageElement
@@ -2146,7 +2146,7 @@ where
                     match kind {
                         ReferenceKind::RefOf => todo!(),
                         ReferenceKind::LocalOrArg => {
-                            if let Object::Reference { kind: inner_kind, inner: inner_inner } = &**inner {
+                            if let Object::Reference { kind: _inner_kind, inner: inner_inner } = &**inner {
                                 // TODO: this should store into the reference, potentially doing an
                                 // implicit cast
                                 unsafe {
@@ -2205,15 +2205,15 @@ where
 
         let read_region = match field.kind {
             FieldUnitKind::Normal { ref region } => region,
-            FieldUnitKind::Bank { ref region, ref bank, bank_value } => {
+            // FieldUnitKind::Bank { ref region, ref bank, bank_value } => {
+            FieldUnitKind::Bank { .. } => {
                 // TODO: put the bank_value in the bank
                 todo!();
-                region
             }
-            FieldUnitKind::Index { ref index, ref data } => {
+            // FieldUnitKind::Index { ref index, ref data } => {
+            FieldUnitKind::Index { .. } => {
                 // TODO: configure the correct index
                 todo!();
-                data
             }
         };
         let Object::OpRegion(ref read_region) = **read_region else { panic!() };
@@ -2265,15 +2265,15 @@ where
 
         let write_region = match field.kind {
             FieldUnitKind::Normal { ref region } => region,
-            FieldUnitKind::Bank { ref region, ref bank, bank_value } => {
+            // FieldUnitKind::Bank { ref region, ref bank, bank_value } => {
+            FieldUnitKind::Bank { .. } => {
                 // TODO: put the bank_value in the bank
                 todo!();
-                region
             }
-            FieldUnitKind::Index { ref index, ref data } => {
+            // FieldUnitKind::Index { ref index, ref data } => {
+            FieldUnitKind::Index { .. } => {
                 // TODO: configure the correct index
                 todo!();
-                data
             }
         };
         let Object::OpRegion(ref write_region) = **write_region else { panic!() };
@@ -2373,8 +2373,9 @@ where
             | RegionSpace::GenericSerialBus
             | RegionSpace::Pcc
             | RegionSpace::Oem(_) => {
-                if let Some(handler) = self.region_handlers.lock().get(&region.space) {
-                    todo!("Utilise handler");
+                if let Some(_handler) = self.region_handlers.lock().get(&region.space) {
+                    warn!("Custom region handlers aren't actually supported yet.");
+                    Err(AmlError::LibUnimplemented)
                 } else {
                     Err(AmlError::NoHandlerForRegionAccess(region.space))
                 }
@@ -2439,8 +2440,9 @@ where
             | RegionSpace::GenericSerialBus
             | RegionSpace::Pcc
             | RegionSpace::Oem(_) => {
-                if let Some(handler) = self.region_handlers.lock().get(&region.space) {
-                    todo!("Utilise handler");
+                if let Some(_handler) = self.region_handlers.lock().get(&region.space) {
+                    warn!("Custom region handlers aren't actually supported yet.");
+                    Err(AmlError::LibUnimplemented)
                 } else {
                     Err(AmlError::NoHandlerForRegionAccess(region.space))
                 }
@@ -3057,9 +3059,15 @@ pub enum AmlError {
 
     MethodArgCountIncorrect,
 
-    InvalidOperationOnObject { op: Operation, typ: ObjectType },
+    InvalidOperationOnObject {
+        op: Operation,
+        typ: ObjectType,
+    },
     IndexOutOfBounds,
-    ObjectNotOfExpectedType { expected: ObjectType, got: ObjectType },
+    ObjectNotOfExpectedType {
+        expected: ObjectType,
+        got: ObjectType,
+    },
 
     InvalidResourceDescriptor,
     UnexpectedResourceType,
@@ -3072,4 +3080,8 @@ pub enum AmlError {
     PrtInvalidGsi,
     PrtInvalidSource,
     PrtNoEntry,
+
+    /// This is emitted to signal that the library does not support the requested behaviour. This
+    /// should eventually never be emitted.
+    LibUnimplemented,
 }

src/aml/object.rs

@@ -44,17 +44,18 @@ impl fmt::Display for Object {
         match self {
             Object::Uninitialized => write!(f, "[Uninitialized]"),
             Object::Buffer(bytes) => write!(f, "Buffer({bytes:x?})"),
-            // TODO: include fields here
-            Object::BufferField { buffer, offset, length } => write!(f, "BufferField {{ .. }}"),
+            Object::BufferField { offset, length, .. } => {
+                write!(f, "BufferField {{ offset: {offset}, length: {length} }}")
+            }
             Object::Device => write!(f, "Device"),
             Object::Event => write!(f, "Event"),
             // TODO: include fields
             Object::FieldUnit(_) => write!(f, "FieldUnit"),
             Object::Integer(value) => write!(f, "Integer({value})"),
             // TODO: decode flags here
-            Object::Method { code, flags } => write!(f, "Method"),
+            Object::Method { .. } => write!(f, "Method"),
             Object::NativeMethod { .. } => write!(f, "NativeMethod"),
-            Object::Mutex { mutex, sync_level } => write!(f, "Mutex"),
+            Object::Mutex { .. } => write!(f, "Mutex"),
             Object::Reference { kind, inner } => write!(f, "Reference({:?} -> {})", kind, **inner),
             Object::OpRegion(region) => write!(f, "{region:?}"),
             Object::Package(elements) => {
@@ -70,9 +71,9 @@ impl fmt::Display for Object {
                 Ok(())
             }
             // TODO: include fields
-            Object::PowerResource { system_level, resource_order } => write!(f, "PowerResource"),
+            Object::PowerResource { .. } => write!(f, "PowerResource"),
             // TODO: include fields
-            Object::Processor { proc_id, pblk_address, pblk_length } => write!(f, "Processor"),
+            Object::Processor { .. } => write!(f, "Processor"),
             Object::RawDataBuffer => write!(f, "RawDataBuffer"),
             Object::String(value) => write!(f, "String({value:?})"),
             Object::ThermalZone => write!(f, "ThermalZone"),

src/lib.rs

@@ -32,7 +32,7 @@
 //! interfaces, such as [`PlatformInfo`], [`PciConfigRegions`], or [`HpetInfo`].
 
 #![no_std]
-#![feature(allocator_api, let_chains)]
+#![feature(allocator_api)]
 
 #[cfg_attr(test, macro_use)]
 #[cfg(test)]