uefi-raw: add Tcp4 protocol type definitions #1797
Open
+517
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
JayKickliter
force-pushed
the
jsk/uefi-raw/add-tcpv4
branch
from
507d349 to
86a97e4
Compare
phip1611
requested changes
Oct 22, 2025
Member
phip1611
left a comment
phip1611
left a comment
There was a problem hiding this comment.
Generally looks very good, thanks for working on this! I left some minor remarks.
Member
|
The typos CI step should be fixed when you add "ANDed" to |
JayKickliter
force-pushed
the
jsk/uefi-raw/add-tcpv4
branch
2 times, most recently
from
3641ccb to
95e20c4
Compare
Member
|
Ping @JayKickliter , what's the status here? |
Author
It should have all review comments addressed now. |
JayKickliter
force-pushed
the
jsk/uefi-raw/add-tcpv4
branch
from
ef0785f to
2f4310b
Compare
Member
|
I think unfortunately, you've missed #1797 (comment) and #1797 (comment) |
JayKickliter
force-pushed
the
jsk/uefi-raw/add-tcpv4
branch
from
2f4310b to
0c0612b
Compare
phip1611
reviewed
Nov 12, 2025
Member
|
almost there, thanks! Just one final thing from my side: #1797 (comment) |
JayKickliter
force-pushed
the
jsk/uefi-raw/add-tcpv4
branch
from
0c0612b to
074ff74
Compare
JayKickliter
changed the title
phip1611
approved these changes
Nov 12, 2025
Member
|
LGTM! how about @nicholasbishop ? |
nicholasbishop
approved these changes
Nov 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is PR 1 of 2 adding TCP functionality to uefi-rs and is a replacement for #1779. I removed the high-level
ueficrate additions and will open a separate PR for them.Checklist