uefi-raw: Add bindings for more HII protocols #1822
+449
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crawfxrd
force-pushed
the
hii-bindings
branch
2 times, most recently
from
89651fd to
96848f4
Compare
phip1611
reviewed
Nov 12, 2025
crawfxrd
force-pushed
the
hii-bindings
branch
from
96848f4 to
6b89cae
Compare
crawfxrd
commented
Nov 12, 2025
| #[derive(Clone, Copy, Debug, Eq, PartialEq, Ord, PartialOrd, Hash)] | ||
| #[repr(transparent)] | ||
| pub struct HiiFontStyle: u32 { | ||
| const NORMAL = 0; |
Contributor
Author
There was a problem hiding this comment.
bitflags recommends against having zero-bit flags. Not sure what to do with UEFI flags that use it as a default/none value.
Just checked, and they're not even used internally by edk2.
Add bindings for the following UEFI 2.11 protocols: - Font (EFI_HII_FONT_PROTOCOL) - Font Ex (EFI_HII_FONT_EX_PROTOCOL) - String (EFI_HII_STRING_PROTOCOL) - Image (EFI_HII_IMAGE_PROTOCOL) - Image Ex (EFI_HII_IMAGE_EX_PROTOCOL) Ref: UEFI 2.11: 34 HII Protocols Signed-off-by: Tim Crawford <tcrawford@system76.com>
crawfxrd
force-pushed
the
hii-bindings
branch
from
6b89cae to
3dfb0d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add bindings for the following UEFI 2.11 protocols:
EFI_HII_FONT_PROTOCOL)EFI_HII_FONT_EX_PROTOCOL)EFI_HII_STRING_PROTOCOL)EFI_HII_IMAGE_PROTOCOL)EFI_HII_IMAGE_EX_PROTOCOL)Ref: UEFI 2.11: 34 HII Protocols
TODO
ImageOutputHiiFontExProtocol.get_glyph_infoAdd HII package definitions for database integration (Section 33.3)?Checklist