cargo clippy fix

Author: cfvescovo

src/iter.rs

@@ -176,8 +176,8 @@ pub struct Children<'a, T: 'a> {
 impl<'a, T: 'a> Clone for Children<'a, T> {
     fn clone(&self) -> Self {
         Self {
-            front: self.front.clone(),
-            back: self.back.clone(),
+            front: self.front,
+            back: self.back,
         }
     }
 }

src/lib.rs

@@ -128,8 +128,8 @@ impl<'a, T: 'a> Eq for NodeRef<'a, T> {}
 impl<'a, T: 'a> PartialEq for NodeRef<'a, T> {
     fn eq(&self, other: &Self) -> bool {
         self.id == other.id
-            && self.tree as *const _ == other.tree as *const _
-            && self.node as *const _ == other.node as *const _
+            && std::ptr::eq(self.tree, other.tree)
+            && std::ptr::eq(self.node, other.node)
     }
 }
 

tests/node_mut.rs

@@ -66,15 +66,15 @@ fn last_child() {
 #[test]
 fn has_siblings() {
     let mut tree = tree!('a' => { 'b', 'c' });
-    assert_eq!(true, tree.root_mut().first_child().unwrap().has_siblings());
-    assert_eq!(false, tree.root_mut().has_siblings());
+    assert!(tree.root_mut().first_child().unwrap().has_siblings());
+    assert!(!tree.root_mut().has_siblings());
 }
 
 #[test]
 fn has_children() {
     let mut tree = tree!('a' => { 'b', 'c' });
-    assert_eq!(true, tree.root_mut().has_children());
-    assert_eq!(false, tree.root_mut().first_child().unwrap().has_children());
+    assert!(tree.root_mut().has_children());
+    assert!(!tree.root_mut().first_child().unwrap().has_children());
 }
 
 #[test]
@@ -310,7 +310,7 @@ fn reparent_from_id_append() {
     let g = b.last_child().unwrap();
     let f = g.prev_sibling().unwrap();
 
-    assert_eq!(false, e.has_children());
+    assert!(!e.has_children());
     assert_eq!(&'f', f.value());
     assert_eq!(&'g', g.value());
     assert_eq!(Some(f), d.next_sibling());
@@ -337,7 +337,7 @@ fn reparent_from_id_prepend() {
     let d = c.next_sibling().unwrap();
     let f = b.last_child().unwrap().prev_sibling().unwrap();
 
-    assert_eq!(false, e.has_children());
+    assert!(!e.has_children());
     assert_eq!(&'c', c.value());
     assert_eq!(&'d', d.value());
     assert_eq!(Some(f), d.next_sibling());

tests/node_ref.rs

@@ -43,22 +43,22 @@ fn last_child() {
 #[test]
 fn has_siblings() {
     let tree = tree!('a' => { 'b', 'c' });
-    assert_eq!(false, tree.root().has_siblings());
-    assert_eq!(true, tree.root().first_child().unwrap().has_siblings());
+    assert!(!tree.root().has_siblings());
+    assert!(tree.root().first_child().unwrap().has_siblings());
 }
 
 #[test]
 fn has_children() {
     let tree = tree!('a' => { 'b', 'c' });
-    assert_eq!(true, tree.root().has_children());
-    assert_eq!(false, tree.root().first_child().unwrap().has_children());
+    assert!(tree.root().has_children());
+    assert!(!tree.root().first_child().unwrap().has_children());
 }
 
 #[test]
 fn clone() {
     let tree = tree!('a');
     let one = tree.root();
-    let two = one.clone();
+    let two = one;
     assert_eq!(one, two);
 }