Skip to content

Commit c417e7a

Browse files
author
Anisa Kusumadewi
committed
Merge branch 'fix-duplicate-entries-in-lang-string' into 'testing'
remove duplicate entries in lang string See merge request moodle_l2p/moodle-mod_pdfannotator!199
2 parents e28b7dc + 1c2efdc commit c417e7a

File tree

4 files changed

+31
-8
lines changed

4 files changed

+31
-8
lines changed

lang/en/pdfannotator.php

Lines changed: 26 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -52,9 +52,11 @@
5252
$string['average_answers'] = 'Average answers';
5353
$string['average_help'] = 'Only users who wrote at least one comment are included in the calculation of the average (arithmetic mean)';
5454
$string['average_questions'] = 'Average questions';
55+
5556
$string['by'] = 'by';
5657
$string['by_other_users'] = 'by other users';
5758
$string['bynameondate'] = 'by {$a->name} - {$a->date}';
59+
5860
$string['cancelButton'] = 'Cancel';
5961
$string['chart_title'] = 'Questions and answers in the annotators in this course';
6062
$string['clicktoopen2'] = 'Click {$a} link to view the file.';
@@ -68,6 +70,7 @@
6870
$string['count'] = 'count';
6971
$string['createAnnotation'] = 'Create Annotation';
7072
$string['currentPage'] = 'current page number';
73+
7174
$string['day'] = 'day';
7275
$string['days'] = 'days';
7376
$string['decision:overlappingAnnotation'] = 'You clicked an area, in which is more than one annotation. Decide which one you wanted to click.';
@@ -87,6 +90,7 @@
8790
$string['dnduploadpdfannotator'] = 'Create file for PDF Annotation';
8891
$string['document'] = 'Document';
8992
$string['drawing'] = 'Draw in the document with the pen.';
93+
9094
$string['edit'] = 'Edit';
9195
$string['editAnnotation'] = 'The annotation will be moved. <br>This might change the context of the question.';
9296
$string['editAnnotationTitle'] = 'Are you sure?';
@@ -110,9 +114,8 @@
110114
$string['error:getAnnotations'] = 'An error has occurred while getting all annotations.';
111115
$string['error:getComments'] = 'An error has occurred while getting the comments.';
112116
$string['error:getimageheight'] = 'An error has occurred while getting image height of {$a}.';
113-
$string['error:getimageheight'] = 'An error has occurred while getting image width of {$a}.';
117+
$string['error:getimagewidth'] = 'An error has occurred while getting image width of {$a}.';
114118
$string['error:getQuestions'] = 'An error has occurred while getting the questions for this page.';
115-
$string['error:printComments'] = 'Error with data from server.';
116119
$string['error:hideComment'] = "An error has occurred while trying to hide the comment from participants' view.";
117120
$string['error:markasread'] = 'The item could not be marked as read.';
118121
$string['error:markasunread'] = 'The item could not be marked as unread.';
@@ -122,17 +125,19 @@
122125
$string['error:openingPDF'] = 'An error occurred while opening the PDF file.';
123126
$string['error:openprintview'] = 'An error has occurred while trying to open the pdf in Acrobat Reader.';
124127
$string['error:printcomments'] = 'An error has occurred while trying to open the comments in a pdf.';
128+
$string['error:printcommentsdata'] = 'Error with data from server.';
125129
$string['error:printlatex'] = 'An error has occurred while trying to add a LaTeX formula to the pdf.';
126130
$string['error:redisplayComment'] = 'An error has occurred while redisplaying the comment.';
127131
$string['error:renderPage'] = 'An error has occurred while rendering the page.';
128132
$string['error:reportComment'] = 'An error has occurred while saving the report.';
129133
$string['error:subscribe'] = 'An error has occurred while subscribing to the question.';
130134
$string['error:unsubscribe'] = 'An error has occurred while unsubscribing to the question.';
131-
$string['error:unsupportedextention'] = 'The extension of submitted data is not supported. Please select other extension.';
135+
$string['error:unsupportedextension'] = 'The extension of submitted data is not supported. Please select other extension.';
132136
$string['error:redihideCommentsplayComment'] = 'An error occurred while re-inserting the comment for attendees.';
133137
$string['error:voteComment'] = 'An error has occurred while saving the vote.';
134138
$string['error'] = 'Error!';
135139
$string['eventreport_added'] = 'A comment was reported';
140+
136141
$string['filenotfound'] = 'File not found, sorry.';
137142
$string['forward'] = 'Forward';
138143
$string['forwardedquestionhtml'] = '{$a->sender} forwarded the following question to you: <br /> <br />
@@ -151,6 +156,7 @@
151156
The question is available at: {$a->urltoquestion}';
152157
$string['fullscreen'] = 'Fullscreen';
153158
$string['fullscreenBack'] = 'Exit Fullscreen';
159+
154160
$string['global_setting_anonymous'] = 'Allow anonymous posting?';
155161
$string['global_setting_anonymous_desc'] = 'With this option you allow your user to post comments anonymously. This option activates anonymous posting globally';
156162
$string['global_setting_attobuttons'] = 'Atto editor toolbar config';
@@ -178,19 +184,23 @@
178184
$string['global_setting_useprint_document_desc'] = 'Allow participants to save and print the pdf document';
179185
$string['global_setting_usevotes'] = 'Allow liking of comments?';
180186
$string['global_setting_usevotes_desc'] = 'With this option users can like / vote for posts other than their own.';
187+
181188
$string['hiddenComment'] = 'hidden comment';
182189
$string['hiddenforparticipants'] = 'Hidden from students';
183190
$string['hideAnnotations'] = 'Hide Annotations';
184191
$string['highlight'] = 'Highlight text and add a comment.';
185192
$string['hour'] = 'hour';
186193
$string['hours'] = 'hours';
194+
187195
$string['in_course'] = 'in this course';
188196
$string['in_document'] = 'in this document';
189197
$string['infonocomments'] = "This document contains no comments at present.";
190198
$string['iscorrecthelpicon'] = 'Correct';
191199
$string['iscorrecthelpicon_help'] = 'When a teacher or manager has marked an answer as correct, a green check mark appears next to it.';
192200
$string['itemsperpage'] = 'Items per page';
201+
193202
$string['justnow'] = 'just now';
203+
194204
$string['lastanswered'] = 'Last Answer';
195205
$string['lastedited'] = 'last edited';
196206
$string['legacyfiles'] = 'Migration of old course file';
@@ -206,6 +216,7 @@
206216
$string['likeQuestion'] = 'interesting question';
207217
$string['likeQuestionForbidden'] = 'already marked as helpful';
208218
$string['loading'] = 'Loading!';
219+
209220
$string['markasread'] = 'Mark as read';
210221
$string['markasunread'] = 'Mark as unread';
211222
$string['markCorrect'] = 'Mark as correct';
@@ -240,6 +251,7 @@
240251
$string['mypublicquestions'] = 'My public questions';
241252
$string['myquestion'] = 'Question';
242253
$string['myquestions'] = 'My questions';
254+
243255
$string['newanswerhtml'] = 'Your subscribed question "{$a->question}" was answered by {$a->answeruser} with the comment: <br /> <br /> "{$a->content}"<br /><br />
244256
The answer is <a href="{$a->urltoanswer}">here</a> available.';
245257
$string['newanswertext'] = 'Your subscribed question "{$a->question}" was answered by {$a->answeruser} with the comment:
@@ -273,6 +285,7 @@
273285
$string['notificationsubject:newquestion'] = 'New question in {$a}';
274286
$string['notificationsubject:newreport'] = 'A comment was reported in {$a}';
275287
$string['nounreadreports'] = 'There are no unread reports in this course at present.';
288+
276289
$string['on'] = 'on';
277290
$string['onlyDeleteOwnAnnotations'] = ", because it belongs to another user.";
278291
$string['onlyDeleteUncommentedPosts'] = ", because the other users comments would be deleted as well.";
@@ -282,6 +295,7 @@
282295
$string['ownpoststab'] = 'My posts';
283296
$string['ownpoststabicon'] = 'My posts';
284297
$string['ownpoststabicon_help'] = 'This page displays all comments that you posted in this course.';
298+
285299
$string['page'] = 'page';
286300
$string['pdfannotator:addinstance'] = 'add instance';
287301
$string['pdfannotator:administrateuserinput'] = 'Administrate comments';
@@ -356,13 +370,15 @@
356370
$string['publicanswers'] = 'Public answers';
357371
$string['public_comments'] = 'Public comments';
358372
$string['publicquestions'] = 'Public questions';
373+
359374
$string['question'] = 'Question';
360375
$string['questionsimgtitle'] = "Show all questions on this page";
361376
$string['questionSolved'] = 'Questions is closed. However, you can still create new comments.';
362377
$string['questionstab'] = 'Questions';
363378
$string['questionstabicon'] = 'Questions';
364379
$string['questionstabicon_help'] = 'This page displays all unsolved questions that were asked in this course. You can also choose to see all or all solved questions in this course.';
365380
$string['questionstitle'] = 'Questions on page';
381+
366382
$string['read'] = 'Read';
367383
$string['reason'] = 'Explanation';
368384
$string['recievenewquestionnotifications'] = 'Notify about new questions';
@@ -389,6 +405,7 @@
389405
$string['reportstabicon'] = 'Reported comments';
390406
$string['reportstabicon_help'] = 'This page displays comments that were reported as inappropriate in this course. You can choose to see only unread/read* reports or all reports.<br>* Any manager of this course can mark a report as read.';
391407
$string['reportwassentoff'] = 'The comment has been reported.';
408+
392409
$string['search'] = 'Search';
393410
$string['searchresults'] = 'Search results';
394411
$string['second'] = 'second';
@@ -451,10 +468,12 @@
451468
$string['successfullyUnsubscribedSingular'] = 'Your subscribtion to the question was cancelled and the only answer removed from this table.';
452469
$string['successfullyUnsubscribedTwo'] = 'Your subscribtion was cancelled. Both answers to the question were removed from this table.';
453470
$string['sumPages'] = 'Number of pages';
471+
454472
$string['text'] = 'Add a text in the document.';
455473
$string['titleforreportcommentform'] = 'Report comment';
456474
$string['titleforwardform'] = 'Forward question';
457475
$string['toreport'] = 'Report';
476+
458477
$string['unseenreports'] = 'unread only';
459478
$string['unsolvedquestionstitle'] = 'Unsolved Questions';
460479
$string['unsolvedquestionstitle_help'] = 'All unsolved questions in this course are listed.';
@@ -470,17 +489,21 @@
470489
$string['use_protected_comments'] = "Allow participants to write private comments?";
471490
$string['useprint_document'] = "Give participants access to the PDF?";
472491
$string['usevotes'] = "Allow users to like comments.";
492+
473493
$string['view'] = 'Document';
474494
$string['votes'] = 'Likes';
475495
$string['voteshelpicon'] = 'Likes';
476496
$string['voteshelpicon_help'] = 'This column tells you how many other people take an interest in the question.';
477497
$string['voteshelpicontwo'] = 'Likes';
478498
$string['voteshelpicontwo_help'] = 'This column tells you how often your posts were <em>liked</em>.';
499+
479500
$string['week'] = 'week';
480501
$string['weeks'] = 'weeks';
502+
481503
$string['year'] = 'year';
482504
$string['years'] = 'years';
483505
$string['yesButton'] = 'Yes';
506+
484507
$string['zoom'] = 'zoom';
485508
$string['zoomin'] = 'zoom in';
486509
$string['zoomout'] = 'zoom out';

locallib.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ function pdfannotator_display_embed($pdfannotator, $cm, $course, $file, $page =
6464
// Load and execute the javascript files.
6565
$PAGE->requires->js(new moodle_url("/mod/pdfannotator/shared/pdf.js?ver=00002"));
6666
$PAGE->requires->js(new moodle_url("/mod/pdfannotator/shared/textclipper.js"));
67-
$PAGE->requires->js(new moodle_url("/mod/pdfannotator/shared/index.js?ver=00037"));
67+
$PAGE->requires->js(new moodle_url("/mod/pdfannotator/shared/index.js?ver=00038"));
6868
$PAGE->requires->js(new moodle_url("/mod/pdfannotator/shared/locallib.js?ver=00006"));
6969

7070
// Pass parameters from PHP to JavaScript.
@@ -202,7 +202,7 @@ function pdfannotator_split_content_image($content, $res, $itemid, $context=null
202202
preg_match('/(https...{1,}[.]((gif)|(jpe)g*|(jpg)|(png)|(svg)|(svgz)))/i', $imgstr, $url);
203203
preg_match('/(gif)|(jpe)g*|(jpg)|(png)|(svg)|(svgz)/i', $url[0], $format);
204204
if (!$format) {
205-
throw new \moodle_exception('error:unsupportedextention', 'pdfannotator');
205+
throw new \moodle_exception('error:unsupportedextension', 'pdfannotator');
206206
}
207207
if (in_array('jpg', $format) || in_array('jpeg', $format) || in_array('jpe', $format)
208208
|| in_array('JPG', $format) || in_array('JPEG', $format) || in_array('JPE', $format)) {

shared/index.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

version.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525
defined('MOODLE_INTERNAL') || die();
2626

2727
$plugin->component = 'mod_pdfannotator';
28-
$plugin->version = 2022112900;
29-
$plugin->release = 'PDF Annotator v1.5 release 2';
28+
$plugin->version = 2022120500;
29+
$plugin->release = 'PDF Annotator v1.5 release 3';
3030
$plugin->requires = 2021051700;
3131
$plugin->maturity = MATURITY_STABLE;

0 commit comments

Comments
 (0)