From e225395f24b89f6e1338b143131cc5a877a50006 Mon Sep 17 00:00:00 2001 From: TrellixVulnTeam Date: Tue, 18 Oct 2022 16:51:09 +0000 Subject: [PATCH] Adding tarfile member sanitization to extractall() --- fitsmap/tests/helpers.py | 21 ++++++++++++++++++++- 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/fitsmap/tests/helpers.py b/fitsmap/tests/helpers.py index bb34318..08f7bce 100644 --- a/fitsmap/tests/helpers.py +++ b/fitsmap/tests/helpers.py @@ -60,7 +60,26 @@ def setup(with_data=False): def extract(f): with tarfile.open(with_test_path(f)) as f: - f.extractall(TEST_PATH) + def is_within_directory(directory, target): + + abs_directory = os.path.abspath(directory) + abs_target = os.path.abspath(target) + + prefix = os.path.commonprefix([abs_directory, abs_target]) + + return prefix == abs_directory + + def safe_extract(tar, path=".", members=None, *, numeric_owner=False): + + for member in tar.getmembers(): + member_path = os.path.join(path, member.name) + if not is_within_directory(path, member_path): + raise Exception("Attempted Path Traversal in Tar File") + + tar.extractall(path, members, numeric_owner=numeric_owner) + + + safe_extract(f, TEST_PATH) any(map(extract, compressed_files))