Removed the use of global scope assertion/stub libraries

to make the dependencies visible

Author: ryu1kn

cli-test-mocha.opts

@@ -1,4 +1,3 @@
 --ui tdd
---require test/bootstrap.js
 --recursive
 test

test/.eslintrc.yaml

@@ -1,9 +1,6 @@
 globals:
-  expect: true
-  sinon: true
   suite: true
   test: true
   beforeEach: true
-  stubWithArgs: true
 rules:
   no-unused-expressions: off

test/bootstrap.js renamed to test/helpers.js

@@ -1,14 +1,16 @@
 const chai = require('chai')
 chai.use(require('sinon-chai'))
 
-global.expect = chai.expect
-global.sinon = require('sinon')
-global.throwErrorIfCalled = () => {
+const sinon = require('sinon')
+
+exports.expect = chai.expect
+exports.sinon = sinon
+exports.throwErrorIfCalled = () => {
   throw new Error("Shouldn't have been called")
 }
 
 // Usage: stubWithArgs([call1Arg1, ...], return1, [call2Arg1, ...], return2, ...)
-global.stubWithArgs = function (...args) {
+exports.stubWithArgs = function (...args) {
   const stub = sinon.stub()
   for (let i = 0; i + 1 < args.length; i += 2) {
     stub.withArgs.apply(stub, args[i]).returns(args[i + 1])

test/index.js

@@ -19,6 +19,4 @@ testRunner.configure({
   useColors: true // colored output from test results
 })
 
-require('./bootstrap')
-
 module.exports = testRunner

test/lib/bootstrapper.test.js

@@ -1,4 +1,5 @@
 const td = require('testdouble')
+const { expect } = require('../helpers')
 
 const Bootstrapper = require('../../lib/bootstrapper')
 

test/lib/clipboard.test.js

@@ -1,3 +1,5 @@
+const { expect } = require('../helpers')
+
 const Clipboard = require('../../lib/clipboard')
 
 suite('Clipboard', () => {

test/lib/commands/compare-selection-with-clipboard.test.js

@@ -1,3 +1,5 @@
+const { expect, sinon, stubWithArgs } = require('../../helpers')
+
 const CompareSelectionWithClipboardCommand = require('../../../lib/commands/compare-selection-with-clipboard')
 
 suite('CompareSelectionWithClipboardCommand', () => {

test/lib/commands/compare-selection-with-text1.test.js

@@ -1,3 +1,5 @@
+const { expect, sinon, stubWithArgs } = require('../../helpers')
+
 const CompareSelectionWithText1 = require('../../../lib/commands/compare-selection-with-text1')
 
 suite('CompareSelectionWithText1', () => {

test/lib/commands/compare-visible-editors.test.js

@@ -1,6 +1,7 @@
-const CompareVisibleEditorsCommand = require('../../../lib/commands/compare-visible-editors')
 const td = require('testdouble')
 
+const CompareVisibleEditorsCommand = require('../../../lib/commands/compare-visible-editors')
+
 suite('CompareVisibleEditorsCommand', () => {
   const editor1 = { viewColumn: 1 }
   const editor2 = { viewColumn: 2 }

test/lib/commands/save-text-1.test.js

@@ -1,3 +1,5 @@
+const { expect, sinon, stubWithArgs } = require('../../helpers')
+
 const SelectText1Command = require('../../../lib/commands/save-text-1')
 
 suite('SelectText1Command', () => {