ref #11 Refactored Bootstrapper

Author: ryu1kn

lib/bootstrapper.js

@@ -10,7 +10,6 @@ class Bootstrapper {
   initiate (context) {
     this._registerProviders(context)
     this._registerCommands(context)
-    this._registerEditorCommands(context)
   }
 
   _registerProviders (context) {
@@ -22,37 +21,43 @@ class Bootstrapper {
   }
 
   _registerCommands (context) {
-    const command = this._commandFactory.createCompareVisibleEditorsCommand()
-    const disposable = this._vscode.commands.registerCommand(
-      `${EXTENSION_NAMESPACE}.diffVisibleEditors`,
-      command.execute,
-      command
-    )
-    context.subscriptions.push(disposable)
-  }
-
-  _registerEditorCommands (context) {
-    const factory = this._commandFactory
-    const commandMap = new Map([
-      [`${EXTENSION_NAMESPACE}.markSection1`, factory.crateSaveText1Command()],
-      [
-        `${EXTENSION_NAMESPACE}.markSection2AndTakeDiff`,
-        factory.createCompareSelectionWithText1Command()
-      ],
-      [
-        `${EXTENSION_NAMESPACE}.diffSelectionWithClipboard`,
-        factory.createCompareSelectionWithClipboardCommand()
-      ]
-    ])
-    commandMap.forEach((command, commandName) => {
-      const disposable = this._vscode.commands.registerTextEditorCommand(
-        commandName,
-        command.execute,
-        command
-      )
+    this._commandList.forEach(command => {
+      const registerer = this._getCommandRegisterer(command.type)
+      const disposable = registerer(command.name, command.command.execute, command.command)
       context.subscriptions.push(disposable)
     })
   }
+
+  _getCommandRegisterer (commandType) {
+    return commandType === 'TEXT_EDITOR'
+      ? this._vscode.commands.registerTextEditorCommand
+      : this._vscode.commands.registerCommand
+  }
+
+  get _commandList () {
+    return [
+      {
+        name: `${EXTENSION_NAMESPACE}.diffVisibleEditors`,
+        type: 'GENERAL',
+        command: this._commandFactory.createCompareVisibleEditorsCommand()
+      },
+      {
+        name: `${EXTENSION_NAMESPACE}.markSection1`,
+        type: 'TEXT_EDITOR',
+        command: this._commandFactory.crateSaveText1Command()
+      },
+      {
+        name: `${EXTENSION_NAMESPACE}.markSection2AndTakeDiff`,
+        type: 'TEXT_EDITOR',
+        command: this._commandFactory.createCompareSelectionWithText1Command()
+      },
+      {
+        name: `${EXTENSION_NAMESPACE}.diffSelectionWithClipboard`,
+        type: 'TEXT_EDITOR',
+        command: this._commandFactory.createCompareSelectionWithClipboardCommand()
+      }
+    ]
+  }
 }
 
 module.exports = Bootstrapper