some typing annotations in combinat/ #41133
Merged
+98
−98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fchapoton
force-pushed
the
typing_combinat_is
branch
from
932dfd6 to
e94d3fb
Compare
vincentmacri
suggested changes
Nov 4, 2025
Member
vincentmacri
left a comment
vincentmacri
left a comment
There was a problem hiding this comment.
Small suggested change to annotate the type of some lists since they are known. Looks good otherwise!
Co-authored-by: Vincent Macri <vincent.macri@ucalgary.ca>
|
Documentation preview for this PR (built with commit 1fae623; changes) is ready! 🎉 |
Member
|
Thanks for the contribution! |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Nov 5, 2025
mainly about `is_something` methods ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about URL: sagemath#41133 Reported by: Frédéric Chapoton Reviewer(s): Frédéric Chapoton, Vincent Macri
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Nov 8, 2025
sagemathgh-41133: some typing annotations in combinat/ mainly about `is_something` methods ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about URL: sagemath#41133 Reported by: Frédéric Chapoton Reviewer(s): Frédéric Chapoton, Vincent Macri
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Nov 8, 2025
sagemathgh-41133: some typing annotations in combinat/ mainly about `is_something` methods ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about URL: sagemath#41133 Reported by: Frédéric Chapoton Reviewer(s): Frédéric Chapoton, Vincent Macri
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Nov 9, 2025
sagemathgh-41133: some typing annotations in combinat/ mainly about `is_something` methods ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about URL: sagemath#41133 Reported by: Frédéric Chapoton Reviewer(s): Frédéric Chapoton, Vincent Macri
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Nov 9, 2025
sagemathgh-41133: some typing annotations in combinat/ mainly about `is_something` methods ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about URL: sagemath#41133 Reported by: Frédéric Chapoton Reviewer(s): Frédéric Chapoton, Vincent Macri
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Nov 10, 2025
sagemathgh-41133: some typing annotations in combinat/ mainly about `is_something` methods ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about URL: sagemath#41133 Reported by: Frédéric Chapoton Reviewer(s): Frédéric Chapoton, Vincent Macri
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mainly about
is_somethingmethods📝 Checklist