Skip to content

Commit 10fa8cc

Browse files
committed
Move XFCC_CONTEXT_KEY to XForwardedClientCert class
1 parent f7e76e0 commit 10fa8cc

File tree

3 files changed

+10
-8
lines changed

3 files changed

+10
-8
lines changed

grpc-contrib/src/main/java/com/salesforce/grpc/contrib/xfcc/XForwardedClientCert.java

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@
77

88
package com.salesforce.grpc.contrib.xfcc;
99

10+
import io.grpc.Context;
11+
1012
import java.util.ArrayList;
1113
import java.util.List;
1214

@@ -15,6 +17,11 @@
1517
* clients or proxies that a request has flowed through, on its way from the client to the server.
1618
*/
1719
public class XForwardedClientCert {
20+
/**
21+
* The metadata key used to access any present {@link XForwardedClientCert} objects.
22+
*/
23+
public static final Context.Key<List<XForwardedClientCert>> XFCC_CONTEXT_KEY = Context.key("x-forwarded-client-cert");
24+
1825
private String by = "";
1926
private String hash = "";
2027
private String san = "";

grpc-contrib/src/main/java/com/salesforce/grpc/contrib/xfcc/XfccServerInterceptor.java

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -21,11 +21,6 @@
2121
* @see <a href="https://github.com/linkerd/linkerd/issues/1153">Linkerd XFCC Header</a>
2222
*/
2323
public class XfccServerInterceptor implements ServerInterceptor {
24-
/**
25-
* The metadata key used to access any present {@link XForwardedClientCert} objects.
26-
*/
27-
public static final Context.Key<List<XForwardedClientCert>> XFCC_CONTEXT_KEY = Context.key("x-forwarded-client-cert");
28-
2924
private static final Metadata.Key<List<XForwardedClientCert>> XFCC_METADATA_KEY = Metadata.Key.of("x-forwarded-client-cert", new XfccMarshaller());
3025

3126
@Override
@@ -37,7 +32,7 @@ public <ReqT, RespT> ServerCall.Listener<ReqT> interceptCall(ServerCall<ReqT, Re
3732
xfccs.addAll(value);
3833
}
3934

40-
Context xfccContext = Context.current().withValue(XFCC_CONTEXT_KEY, xfccs);
35+
Context xfccContext = Context.current().withValue(XForwardedClientCert.XFCC_CONTEXT_KEY, xfccs);
4136
return Contexts.interceptCall(xfccContext, call, headers, next);
4237
} else {
4338
return next.startCall(call, headers);

grpc-contrib/src/test/java/com/salesforce/grpc/contrib/xfcc/XfccServerInterceptorTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ public void endToEndTest() {
3333
GreeterGrpc.GreeterImplBase svc = new GreeterGrpc.GreeterImplBase() {
3434
@Override
3535
public void sayHello(HelloRequest request, StreamObserver<HelloResponse> responseObserver) {
36-
certs.set(XfccServerInterceptor.XFCC_CONTEXT_KEY.get());
36+
certs.set(XForwardedClientCert.XFCC_CONTEXT_KEY.get());
3737

3838
responseObserver.onNext(HelloResponse.newBuilder().setMessage("Hello " + request.getName()).build());
3939
responseObserver.onCompleted();
@@ -65,7 +65,7 @@ public void endToEndTestMultiple() {
6565
GreeterGrpc.GreeterImplBase svc = new GreeterGrpc.GreeterImplBase() {
6666
@Override
6767
public void sayHello(HelloRequest request, StreamObserver<HelloResponse> responseObserver) {
68-
certs.set(XfccServerInterceptor.XFCC_CONTEXT_KEY.get());
68+
certs.set(XForwardedClientCert.XFCC_CONTEXT_KEY.get());
6969

7070
responseObserver.onNext(HelloResponse.newBuilder().setMessage("Hello " + request.getName()).build());
7171
responseObserver.onCompleted();

0 commit comments

Comments
 (0)