Working on features and bugfixes - organization

[davidp57]

Hi @sam1am!

Thank you for taking the time to make the review of my PRs.

These PRs exist because I like your project and I wanted to add features that I want it to have.
I understand that I 've done this in a wrong way, and that I've put you in a delicate situation.
You've been right to protect your work from that kind of errors.

I'll start anew, on a single feature PR, and patiently wait until we discuss it, merge it and deploy it.
Then I'll start a new one, and we'll work iteratively.
What do you think?

Let's talk about the features that I want to add.

The first one would be an easy way to edit the games metadata, on the games detail page AND in the library.

I'll show you what I did (as an example - I'll redo it completely).

In the library

Trigger (red arrow added in post prod)

Select (red circles added):

Action on selected games:

In the games details

Edit bar (red rectangles added):

Edit menus:

Edit actions (clicking the "edit" button):

[sam1am]

I like these changes. I will review the PR once submitted. Thanks for cleaning things up a bit and I definitely appreciate your work!

[davidp57]

Hi @sam1am!
I made a new PR, this time with a single feature, and very limited changes.
I'm waiting for your review before doing anything else!

[davidp57]

Thank you @sam1am for this quick review and merge of my PR #73.

Now I'm going to tackle issue #74 and propose a new PR.

[davidp57]

Done!
While I wait for you to integrate my PR, I'll work on issue #76.

[davidp57]

Issue #76 is a non-issue, I'll close it

[davidp57]

@sam1am, my next PR will be about enhancing the select-and-edit UI.

• multiselect using control and shift in the library (range + discrete)
• add the action buttons (hide, delete, mark NSFW) to the single-game edit dialog
• make the games detail page metadata edit feature UI better

Is this a good plan in your opinion?