refactor: improve code readability and efficiency - replace deprecated methods with idiomatic alternatives in Git provider and update variable naming for clarity

Author: san0808

src/git.rs

@@ -10,7 +10,7 @@ pub fn is_git_repository() -> bool {
         .stdout(Stdio::null())
         .stderr(Stdio::null())
         .status()
-        .map_or(false, |status| status.success())
+        .is_ok_and(|status| status.success())
 }
 
 /// Gets the diff of staged files.

src/main.rs

@@ -1,7 +1,7 @@
 use clap::Parser;
 use colored::*;
 use question::{Answer, Question};
-use rustyline::{DefaultEditor, Result as RustyResult};
+use rustyline::DefaultEditor;
 use spinners::{Spinner, Spinners};
 use std::process::Command;
 

src/providers/anthropic.rs

@@ -94,7 +94,7 @@ Analyze the git diff carefully and generate an appropriate conventional commit m
 
         let text = anthropic_response
             .content
-            .get(0)
+            .first()
             .map(|c| &c.text)
             .ok_or("Invalid response structure from Anthropic".to_string())?;
 

src/providers/gemini.rs

@@ -107,8 +107,8 @@ Analyze the git diff carefully and generate an appropriate conventional commit m
 
         let text = gemini_response
             .candidates
-            .get(0)
-            .and_then(|c| c.content.parts.get(0))
+            .first()
+            .and_then(|c| c.content.parts.first())
             .map(|p| &p.text)
             .ok_or("Invalid response structure from Gemini".to_string())?;
 

src/providers/mod.rs

@@ -65,6 +65,7 @@ impl GeneratedCommit {
     }
 
     /// Gets a summary of the commit for display
+    #[allow(dead_code)]
     pub fn summary(&self) -> String {
         format!(
             "Type: {}, Files: {}",
@@ -74,6 +75,7 @@ impl GeneratedCommit {
     }
 
     /// Extracts the commit type from the title
+    #[allow(dead_code)]
     pub fn get_type(&self) -> String {
         if let Some(colon_pos) = self.title.find(':') {
             let prefix = &self.title[..colon_pos];
@@ -88,9 +90,9 @@ impl GeneratedCommit {
     }
 }
 
-impl ToString for GeneratedCommit {
-    fn to_string(&self) -> String {
-        format!("{}\n\n{}", self.title, self.description)
+impl std::fmt::Display for GeneratedCommit {
+    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
+        write!(f, "{}\n\n{}", self.title, self.description)
     }
 }
 

src/providers/openai.rs

@@ -44,7 +44,7 @@ impl OpenAIProvider {
 #[async_trait]
 impl AIProvider for OpenAIProvider {
     async fn generate_commit_message(&self, diff: &str) -> Result<GeneratedCommit, String> {
-        let parameters_schema = serde_json::to_value(schemars::schema_for!(Commit))
+        let _parameters_schema = serde_json::to_value(schemars::schema_for!(Commit))
             .map_err(|e| format!("Failed to create schema: {}", e))?;
 
         let system_prompt = "You are an expert programmer who writes git commit messages following the Conventional Commits specification (https://www.conventionalcommits.org/en/v1.0.0/).
@@ -97,7 +97,7 @@ Analyze the git diff carefully and generate an appropriate conventional commit m
 
         let choice = response
             .choices
-            .get(0)
+            .first()
             .ok_or("No response choice from OpenAI".to_string())?;
 
         let function_details = &choice