[Code Bug]: Some figures not displaying properly in Jupyter Notebooks

[jehsharp]

Contact Details

No response

What happened?

When running some of the Jupyter Notebooks (tested on target_identification and enclosed_energy) some of the figures do not display properly. See image.

Version

latest develop

What OS are you seeing this on?

Windows

Relevant dependency versions

python script that produces the error

Run either target_identification.ipynb or enclosed_energy.ipynb. You will have to set up experiment_settings.ini.

Relevant console output

Contribution Guidelines

• I agree to follow this project's contribution guidelines

[bbean23]

This issue is in direct conflict with #305 which attempts to address this bug from a different perspective:

• This issue views the incomplete visualizations not showing up in the notebook as the problem. The solution merged into develop in bbean23@e9aba77 addresses this by always showing the visualization from within the VisualizationImageProcessor.
• Issue 305 views the incomplete visualizaitons showing up at all as the problem. The solution in 305 code bug visualizations are unexpectedly shown in jupyter notebooks #313 addresses this by only automatically showing visualizations when not in a notebook and therefore only showing visualizations in a notebook when directly requested.

In simpler terms, bbean23@e9aba77 always shows the visualizations, but #313 never shows the visualizations.

[bbean23]

Which solution is "correct" is a judgement call. I will say that the more standard approach is with #313, as that more closely mimics the existing behavior of other python libraries in Jupyter notebooks.