Skip to content
This repository was archived by the owner on Sep 3, 2024. It is now read-only.

Commit 1b22dea

Browse files
committed
Update CHANGELOG
1 parent 38be2fa commit 1b22dea

File tree

1 file changed

+9
-4
lines changed

1 file changed

+9
-4
lines changed

CHANGELOG.md

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,20 +20,25 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
2020
## [0.4.0] <!-- YYYY-MM-DD --> [Unreleased]
2121
#### Added
2222
#### Changed
23-
- TODO: Add notes for !16/!17 // TRILFRAME-120 + TRILFRAME-136
2423
- Changes to `opt-set-cmake-var` behaviour:
2524
- Trigger a WARNING if `PARENT_SCOPE` and a _TYPE_ is provided since CMake
2625
requires TYPED vars to be CACHE vars and `PARENT_SCOPE` will force the
2726
var to be considered a non CACHE var that would store the parameters
28-
before `PARENT_SCOPE` in the call as _list_ entries.
27+
before `PARENT_SCOPE` in the call as _list_ entries. (TRILFRAME-128)
2928
- Trigger an exception if `PARENT_SCOPE` and `FORCE` are both provided since
3029
`FORCE` is only valid for CACHE variables but `PARENT_SCOPE` is only valid
3130
for non-CACHE vars (and as noted above will _force_ the `set()` operation
3231
to be a non-CACHE var which then triggers a CMake error because `FORCE` is
33-
invalid to that form of `set()`.
32+
invalid to that form of `set()`. (TRILFRAME-128)
3433
- **bash** generated options that have a TYPE and `PARENT_SCOPE` are processed
3534
to generate the same _list_ string that would be generated by the matching
36-
`set()` operation (with the warning).
35+
`set()` operation (with the warning). (TRILFRAME-128)
36+
- For **bash** generation, trigger a WARNING and DO NOT generate the `-D` CLI option
37+
if `opt-set-cmake-var` without `FORCE` is called on a CMake Cache variable that has
38+
already been set. (TRILFRAME-120).
39+
- For **bash** generation, trigger a WARNING and DO NOT generate the `-D` CLI option
40+
if `opt-set-cmake-var` is called on a non-cache CMake variable. (TRILFRAME-136)
41+
- For **bash** generation, always add a _TYPE_ to the `-D` CLI option. (TRILFRAME-136)
3742
- Revert(ish) the modifications from MR12 which removed the error when generating
3843
BASH output if there is an unhandled CMake variable left hanging around.
3944
Rather than make this an unavoidable error though, ExpandVarsInText now inherits

0 commit comments

Comments
 (0)