Skip to content

Commit f84e867

Browse files
ntkmenex3
andauthored
Fix JS API legacy SassColor.change (#2368)
Co-authored-by: Natalie Weizenbaum <nweiz@google.com>
1 parent 72612c4 commit f84e867

File tree

7 files changed

+22
-5
lines changed

7 files changed

+22
-5
lines changed

CHANGELOG.md

+7
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,10 @@
1+
## 1.79.4
2+
3+
### JS API
4+
5+
* Fix a bug where passing `green` or `blue` to `color.change()` for legacy
6+
colors would fail.
7+
18
## 1.79.3
29

310
* Update the `$channel` parameter in the suggested replacement for

lib/src/js/value/color.dart

+3-1
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,9 @@ final JSClass colorClass = () {
116116
hasProperty(options, 'saturation') ||
117117
hasProperty(options, 'lightness')) {
118118
space = ColorSpace.hsl;
119-
} else if (hasProperty(options, 'red')) {
119+
} else if (hasProperty(options, 'red') ||
120+
hasProperty(options, 'green') ||
121+
hasProperty(options, 'blue')) {
120122
space = ColorSpace.rgb;
121123
}
122124
if (space != self.space) {

pkg/sass-parser/CHANGELOG.md

+4
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
## 0.2.3
2+
3+
* No user-visible changes.
4+
15
## 0.2.2
26

37
* No user-visible changes.

pkg/sass-parser/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "sass-parser",
3-
"version": "0.2.2",
3+
"version": "0.2.3",
44
"description": "A PostCSS-compatible wrapper of the official Sass parser",
55
"repository": "sass/sass",
66
"author": "Google Inc.",

pkg/sass_api/CHANGELOG.md

+4
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
## 12.0.4
2+
3+
* No user-visible changes.
4+
15
## 12.0.3
26

37
* No user-visible changes.

pkg/sass_api/pubspec.yaml

+2-2
Original file line numberDiff line numberDiff line change
@@ -2,15 +2,15 @@ name: sass_api
22
# Note: Every time we add a new Sass AST node, we need to bump the *major*
33
# version because it's a breaking change for anyone who's implementing the
44
# visitor interface(s).
5-
version: 12.0.3
5+
version: 12.0.4
66
description: Additional APIs for Dart Sass.
77
homepage: https://github.com/sass/dart-sass
88

99
environment:
1010
sdk: ">=3.0.0 <4.0.0"
1111

1212
dependencies:
13-
sass: 1.79.3
13+
sass: 1.79.4
1414

1515
dev_dependencies:
1616
dartdoc: ^8.0.14

pubspec.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
name: sass
2-
version: 1.79.3
2+
version: 1.79.4
33
description: A Sass implementation in Dart.
44
homepage: https://github.com/sass/dart-sass
55

0 commit comments

Comments
 (0)