Skip to content

Commit 46007ea

Browse files
committed
Fix #50: Add jsdom 16 back to CI
The problem was a newer version of whatwg-url which attempted to use `globalNames.some` where `globalNames` was undefined (jsdom/whatwg-url#166). Downgrading whatwg-url manually to 8.0.0 (in package-lock.json) fixed the problem.
1 parent 33eaaae commit 46007ea

File tree

3 files changed

+1654
-1
lines changed

3 files changed

+1654
-1
lines changed

.github/workflows/ci.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ jobs:
1313
fail-fast: false
1414
matrix:
1515
scalaversion: ["2.11.12", "2.12.10", "2.13.1"]
16-
jsdomversion: ["10.0.0"] # TODO: add "16.0.0"
16+
jsdomversion: ["10.0.0", "16.0.0"]
1717
steps:
1818
- uses: actions/checkout@v2
1919
- uses: olafurpg/setup-scala@v10

0 commit comments

Comments
 (0)