Merge pull request #5731 from panacekcz/fix-5690

Fix assertion error in #5690

Author: Blaisorblade

compiler/src/dotty/tools/dotc/core/classfile/ClassfileParser.scala

@@ -661,7 +661,7 @@ class ClassfileParser(
           val constr = ctx.newSymbol(
             owner = classRoot.symbol,
             name = nme.CONSTRUCTOR,
-            flags = Flags.Synthetic | Flags.JavaDefined,
+            flags = Flags.Synthetic | Flags.JavaDefined | Flags.Method,
             info = constrType
           ).entered
           for ((attr, i) <- attrs.zipWithIndex)

tests/pending/neg/i5690.scala

@@ -0,0 +1,8 @@
+// instantiating java annotations should not be allowed 
+// (would fail at runtime with java.lang.InstantiationError)
+// see tests/pos/i5690.scala
+object AnnotInst{
+  def main(a: Array[String]) = {
+    new java.lang.annotation.Inherited // error
+  }
+}

tests/pos/i5690.scala

@@ -0,0 +1,8 @@
+// TODO: this should be a compilation error
+// program fails at runtime with java.lang.InstantiationError
+// see tests/pending/neg/i5690.scala
+object AnnotInst{
+  def main(a: Array[String]) = {
+    new java.lang.annotation.Inherited
+  }
+}