Review feedback

Author: Diego Ardila

nucleus/annotation.py

@@ -215,8 +215,8 @@ def check_all_annotation_paths_remote(
     annotations: Sequence[Union[Annotation]],
 ):
     for annotation in annotations:
-        if hasattr(annotation, "mask_url"):
-            if is_local_path(getattr(annotation, "mask_url")):
+        if hasattr(annotation, MASK_URL_KEY):
+            if is_local_path(getattr(annotation, MASK_URL_KEY)):
                 raise ValueError(
                     f"Found an annotation with a local path, which cannot be uploaded asynchronously. Use a remote path instead. {annotation}"
                 )

nucleus/model.py

@@ -45,7 +45,7 @@ def create_run(
             Union[BoxPrediction, PolygonPrediction, SegmentationPrediction]
         ],
         metadata: Optional[Dict] = None,
-        asynchronous=False,
+        asynchronous: bool = False,
     ) -> ModelRun:
         payload: dict = {
             NAME_KEY: name,

nucleus/model_run.py

@@ -8,6 +8,7 @@
     ANNOTATIONS_KEY,
     BOX_TYPE,
     DEFAULT_ANNOTATION_UPDATE_MODE,
+    JOB_ID_KEY,
     POLYGON_TYPE,
     REQUEST_ID_KEY,
     SEGMENTATION_TYPE,
@@ -115,7 +116,7 @@ def predict(
                 route=f"modelRun/{self.model_run_id}/predict?async=1",
             )
 
-            return AsyncJob(response["job_id"], self._client)
+            return AsyncJob(response[JOB_ID_KEY], self._client)
         else:
             return self._client.predict(self.model_run_id, annotations, update)