Review comments + bump version

Author: Diego Ardila

nucleus/__init__.py

@@ -184,9 +184,7 @@ def list_models(self) -> List[Model]:
                 model_id=model["id"],
                 name=model["name"],
                 reference_id=model["ref_id"],
-                metadata=None
-                if model["metadata"] == {}
-                else model["metadata"],
+                metadata=model["metadata"] or None,
                 client=self,
             )
             for model in model_objects["models"]

nucleus/annotation.py

@@ -307,7 +307,7 @@ def to_payload(self) -> dict:
         }
 
 
-def check_all_annotation_paths_remote(
+def check_all_mask_paths_remote(
     annotations: Sequence[Union[Annotation]],
 ):
     for annotation in annotations:

nucleus/dataset.py

@@ -13,7 +13,7 @@
 from .annotation import (
     Annotation,
     CuboidAnnotation,
-    check_all_annotation_paths_remote,
+    check_all_mask_paths_remote,
 )
 from .constants import (
     DATASET_ITEM_IDS_KEY,
@@ -171,7 +171,7 @@ def annotate(
         if any((isinstance(ann, CuboidAnnotation) for ann in annotations)):
             raise NotImplementedError("Cuboid annotations not yet supported")
 
-        check_all_annotation_paths_remote(annotations)
+        check_all_mask_paths_remote(annotations)
 
         if asynchronous:
             request_id = serialize_and_write_to_presigned_url(

nucleus/model.py

@@ -48,9 +48,7 @@ def from_json(cls, payload: dict, client):
             model_id=payload["id"],
             name=payload["name"],
             reference_id=payload["ref_id"],
-            metadata=None
-            if payload["metadata"] == {}
-            else payload["metadata"],
+            metadata=payload["metadata"] or None,
             client=client,
         )
 

nucleus/model_run.py

@@ -1,6 +1,6 @@
 from typing import Dict, List, Optional, Type, Union
 
-from nucleus.annotation import check_all_annotation_paths_remote
+from nucleus.annotation import check_all_mask_paths_remote
 from nucleus.job import AsyncJob
 from nucleus.utils import serialize_and_write_to_presigned_url
 
@@ -106,7 +106,7 @@ def predict(
         }
         """
         if asynchronous:
-            check_all_annotation_paths_remote(annotations)
+            check_all_mask_paths_remote(annotations)
 
             request_id = serialize_and_write_to_presigned_url(
                 annotations, self._dataset_id, self._client

pyproject.toml

@@ -21,7 +21,7 @@ exclude = '''
 
 [tool.poetry]
 name = "scale-nucleus"
-version = "0.1.11"
+version = "0.1.13"
 description = "The official Python client library for Nucleus, the Data Platform for AI"
 license =  "MIT"
 authors = ["Scale AI Nucleus Team <nucleusapi@scaleapi.com>"]