Skip to content

BUG: in checkIfShouldMerge function #2

@tyuownu

Description

@tyuownu

Dear all, I found a bug in checkIfShouldMerge function. See below:

mergedSensorReadings = S1.sensorReadings.concat(S2.sensorReadings);
fit = _SENSOR_READING_UTILS.linearRegerssion(mergedSensorReadings);

in the first line, we shoud delete the duplicate point the S1 and S2, to construct a new pointcloud, beacuse the duplicate will affect the fit in the next line linearRegerssion function.

I do not know the language that this repo used, so I can not help to fix it, lol. Thanks

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions