Skip to content

Add dependency Dancer2::Template::Simple #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
phracek merged 2 commits into from
Sep 22, 2025
Merged

Add dependency Dancer2::Template::Simple #100

phracek merged 2 commits into from
Sep 22, 2025

Conversation

@jplesnik
Copy link
Member

@jplesnik jplesnik commented Sep 18, 2025

It was removed from Dancer2 core since 2.0.0

@jplesnik
Add dependency Dancer2::Template::Simple
2c4bc65 
It was removed from Dancer2 core since 2.0.0
@phracek phracek self-requested a review September 18, 2025 08:40
@phracek
Copy link
Member

phracek commented Sep 18, 2025

[test]

phracek
phracek approved these changes Sep 18, 2025
View reviewed changes
Copy link
Member

@phracek phracek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding dependency LGTM. Let's wait for the tests.

phracek
phracek requested changes Sep 18, 2025
View reviewed changes
Copy link
Member

@phracek phracek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please have a look once more

@phracek
Copy link
Member

phracek commented Sep 18, 2025 •
edited
Loading

The output from build is:

--> Working on Ref::Util::XS
Fetching https://www.cpan.org/authors/id/X/XS/XSAWYERX/Ref-Util-XS-0.117.tar.gz ... OK
Configuring Ref-Util-XS-0.117 ... OK
Building Ref-Util-XS-0.117 ... OK
Successfully installed Ref-Util-XS-0.117
Building Ref-Util-0.204 ... OK
Successfully installed Ref-Util-0.204
Building Data-Censor-0.04 ... OK
Successfully installed Data-Censor-0.04
--> Working on Module::Pluggable
Fetching https://www.cpan.org/authors/id/S/SI/SIMONW/Module-Pluggable-6.3.tar.gz ... OK
/usr/bin/tar: Ignoring unknown extended header keyword 'LIBARCHIVE.xattr.com.apple.metadata:kMDItemTextContentLanguage'
/usr/bin/tar: Ignoring unknown extended header keyword 'LIBARCHIVE.xattr.com.apple.metadata:kMDItemKeyphraseVersion'
/usr/bin/tar: Ignoring unknown extended header keyword 'LIBARCHIVE.xattr.com.apple.metadata:kMDItemKeyphraseLabels'
/usr/bin/tar: Ignoring unknown extended header keyword 'LIBARCHIVE.xattr.com.apple.metadata:kMDItemKeyphraseConfidences'
/usr/bin/tar: Ignoring unknown extended header keyword 'LIBARCHIVE.xattr.com.macromates.visibleIndex'
/usr/bin/tar: Ignoring unknown extended header keyword 'LIBARCHIVE.xattr.com.macromates.selectionRange'
/usr/bin/tar: Ignoring unknown extended header keyword 'LIBARCHIVE.xattr.com.apple.metadata:kMDItemTextContentLanguage'
/usr/bin/tar: Ignoring unknown extended header keyword 'LIBARCHIVE.xattr.com.apple.metadata:kMDItemKeyphraseVersion'
/usr/bin/tar: Ignoring unknown extended header keyword 'LIBARCHIVE.xattr.com.apple.metadata:kMDItemKeyphraseLabels'
/usr/bin/tar: Ignoring unknown extended header keyword 'LIBARCHIVE.xattr.com.apple.metadata:kMDItemKeyphraseConfidences'
/usr/bin/tar: Ignoring unknown extended header keyword 'LIBARCHIVE.xattr.com.macromates.visibleIndex'
/usr/bin/tar: Ignoring unknown extended header keyword 'LIBARCHIVE.xattr.com.macromates.selectionRange'
/usr/bin/tar: Ignoring unknown extended header keyword 'LIBARCHIVE.xattr.com.macromates.visibleIndex'
/usr/bin/tar: Ignoring unknown extended header keyword 'LIBARCHIVE.xattr.com.macromates.selectionRange'
/usr/bin/tar: Ignoring unknown extended header keyword 'LIBARCHIVE.xattr.com.macromates.visibleIndex'
/usr/bin/tar: Ignoring unknown extended header keyword 'LIBARCHIVE.xattr.com.macromates.selectionRange'
/usr/bin/tar: Ignoring unknown extended header keyword 'LIBARCHIVE.xattr.com.macromates.visibleIndex'
/usr/bin/tar: Ignoring unknown extended header keyword 'LIBARCHIVE.xattr.com.macromates.selectionRange'

/usr/bin/tar: Ignoring unknown extended header keyword 'LIBARCHIVE.xattr.com.macromates.caret'
/usr/bin/tar: Ignoring unknown extended header keyword 'LIBARCHIVE.xattr.com.macromates.visibleIndex'
/usr/bin/tar: Ignoring unknown extended header keyword 'LIBARCHIVE.xattr.com.macromates.selectionRange'
/usr/bin/tar: Ignoring unknown extended header keyword 'LIBARCHIVE.xattr.com.macromates.caret'
/usr/bin/tar: Ignoring unknown extended header keyword 'LIBARCHIVE.xattr.com.macromates.visibleIndex'
/usr/bin/tar: Ignoring unknown extended header keyword 'LIBARCHIVE.xattr.com.macromates.selectionRange'
/usr/bin/tar: Ignoring unknown extended header keyword 'LIBARCHIVE.xattr.com.macromates.visibleIndex'
/usr/bin/tar: Ignoring unknown extended header keyword 'LIBARCHIVE.xattr.com.macromates.selectionRange'
/usr/bin/tar: Ignoring unknown extended header keyword 'LIBARCHIVE.xattr.com.macromates.caret'
/usr/bin/tar: Ignoring unknown extended header keyword 'LIBARCHIVE.xattr.com.macromates.visibleIndex'
/usr/bin/tar: Ignoring unknown extended header keyword 'LIBARCHIVE.xattr.com.macromates.selectionRange'
/usr/bin/tar: Ignoring unknown extended header keyword 'LIBARCHIVE.xattr.com.macromates.visibleIndex'
/usr/bin/tar: Ignoring unknown extended header keyword 'LIBARCHIVE.xattr.com.macromates.selectionRange'
/usr/bin/tar: Ignoring unknown extended header keyword 'LIBARCHIVE.xattr.com.macromates.visibleIndex'
/usr/bin/tar: Ignoring unknown extended header keyword 'LIBARCHIVE.xattr.com.macromates.selectionRange'
Configuring Module-Pluggable-6.3 ... OK

@phracek
Copy link
Member

phracek commented Sep 22, 2025

@michal-josef-spacek Do you have any idea, what's wrong?

@phracek
Specify Dancer2 -> "0"
14ae3c8 
Add also reference to PR_NUMBER instead of master

Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
@phracek
Copy link
Member

phracek commented Sep 22, 2025

@michal-josef-spacek solved by 14ae3c8

[test]

phracek
phracek approved these changes Sep 22, 2025
View reviewed changes
Copy link
Member

@phracek phracek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good and tests passed.

@phracek phracek merged commit d6e05b4 into sclorg:master Sep 22, 2025
9 checks passed
@michal-josef-spacek
Copy link
Member

michal-josef-spacek commented Sep 22, 2025

Interesting, maybe because Dancer2 2.0.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@phracek phracek phracek approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jplesnik @phracek @michal-josef-spacek