Skip to content

Commit d52dbc7

Browse files
Upgraded react to v17, fixed #6
1 parent 971323c commit d52dbc7

File tree

9 files changed

+7
-441
lines changed

9 files changed

+7
-441
lines changed

README.md

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77

88
Develop React applications with Scala.
99

10-
It is compatible with Scala `2.12`, `2.13`, Scala.js `0.6.29`, `1.1.0` and with React.js `v16.8+`.
10+
It is compatible with Scala `2.12`, `2.13`, Scala.js `0.6.29`, `1.1.0` and with React.js `v17+`.
1111

1212
Optionally include `react-router` and `react-redux` facades, too.
1313

@@ -49,7 +49,6 @@ ReactDOM.render(<.div(^.id := "hello-world")("Hello, World!"), mountNode)
4949
"org.scommons.shogowada" %%% "scalajs-reactjs-dom" % "0.16.0", // For react-dom facade
5050
5151
"org.scommons.shogowada" %%% "scalajs-reactjs-router-dom" % "0.16.0", // Optional. For react-router-dom facade
52-
"org.scommons.shogowada" %%% "scalajs-reactjs-router-redux" % "0.16.0", // Optional. For react-router-redux facade
5352
"org.scommons.shogowada" %%% "scalajs-reactjs-redux" % "0.16.0", // Optional. For react-redux facade
5453
"org.scommons.shogowada" %%% "scalajs-reactjs-redux-devtools" % "0.16.0" // Optional. For redux-devtools facade
5554
)
@@ -62,7 +61,6 @@ ReactDOM.render(<.div(^.id := "hello-world")("Hello, World!"), mountNode)
6261
- [Router](/example/routing/src/main/scala/io/github/shogowada/scalajs/reactjs/example/router/Main.scala)
6362
- [Redux](/example/todo-app-redux/src/main/scala/io/github/shogowada/scalajs/reactjs/example/todoappredux)
6463
- [Redux Middleware](/example/redux-middleware/src/main/scala/io/github/shogowada/scalajs/reactjs/example/redux/middleware/Main.scala)
65-
- [Router Redux](/example/router-redux/src/main/scala/io/github/shogowada/scalajs/reactjs/example/router/redux/Main.scala)
6664
- [Redux DevTools](/example/redux-devtools/src/main/scala/io/github/shogowada/scalajs/reactjs/example/redux/devtools/Main.scala)
6765
- [I don't like `<` and `^`. How can I change them?](/example/custom-virtual-dom)
6866

build.sbt

Lines changed: 5 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,11 @@
11
val HistoryVersion = "^4.6.1"
2-
val ReactVersion = "^16.8.0"
3-
val ReactReduxVersion = "^5.0.3"
4-
val ReactRouterVersion = "^4.0.0"
5-
val ReactRouterReduxVersion = "next"
2+
val ReactVersion = "^17.0.1"
3+
val ReactReduxVersion = "^7.2.4"
4+
val ReactRouterVersion = "^5.2.1"
65
val ReduxVersion = "^3.6.0"
76
val ReduxDevToolsVersion = "^2.13.0"
87

9-
val StaticTagsVersion = "2.6.1"
8+
val StaticTagsVersion = "2.7.0-SNAPSHOT"
109

1110
val commonSettings = Seq(
1211
organization := "org.scommons.shogowada",
@@ -17,7 +16,7 @@ val commonSettings = Seq(
1716
"-deprecation", "-unchecked", "-feature", "-Xcheckinit", "-target:jvm-1.8", "-Xfatal-warnings"
1817
),
1918

20-
//resolvers += "Sonatype Snapshots" at "https://oss.sonatype.org/content/repositories/snapshots/",
19+
resolvers += "Sonatype Snapshots" at "https://oss.sonatype.org/content/repositories/snapshots/",
2120

2221
sonatypeProfileName := "org.scommons",
2322
publishArtifact := false,
@@ -72,7 +71,6 @@ lazy val root = (project in file("."))
7271
routerDom,
7372
redux,
7473
reduxDevTools,
75-
routerRedux,
7674
exampleCustomVirtualDOM,
7775
exampleHelloWorld,
7876
exampleHelloWorldFunction,
@@ -81,7 +79,6 @@ lazy val root = (project in file("."))
8179
exampleReduxDevTools,
8280
exampleReduxMiddleware,
8381
exampleRouter,
84-
exampleRouterRedux,
8582
exampleStyle,
8683
exampleTodoApp,
8784
exampleTodoAppRedux,
@@ -191,20 +188,6 @@ lazy val reduxDevTools = project.in(file("redux-devtools"))
191188
.enablePlugins(ScalaJSPlugin, ScalaJSBundlerPlugin)
192189
.dependsOn(redux)
193190

194-
lazy val routerRedux = project.in(file("router-redux"))
195-
.settings(commonSettings: _*)
196-
.settings(
197-
name := "scalajs-reactjs-router-redux",
198-
npmDependencies in Compile ++= Seq(
199-
"react-router-redux" -> ReactRouterReduxVersion
200-
),
201-
(webpack in(Compile, fastOptJS)) := Seq(),
202-
(webpack in(Compile, fullOptJS)) := Seq(),
203-
publishArtifact := true
204-
)
205-
.enablePlugins(ScalaJSPlugin, ScalaJSBundlerPlugin)
206-
.dependsOn(history, router, redux)
207-
208191
val exampleCommonSettings = commonSettings ++ Seq(
209192
name := "scalajs-reactjs-example",
210193
scalaJSUseMainModuleInitializer := true,
@@ -275,14 +258,6 @@ lazy val exampleRouter = project.in(file("example") / "router")
275258
.enablePlugins(ScalaJSPlugin, ScalaJSBundlerPlugin)
276259
.dependsOn(dom, routerDom)
277260

278-
lazy val exampleRouterRedux = project.in(file("example") / "router-redux")
279-
.settings(exampleCommonSettings: _*)
280-
.settings(
281-
name += "-router-redux"
282-
)
283-
.enablePlugins(ScalaJSPlugin, ScalaJSBundlerPlugin)
284-
.dependsOn(dom, redux, routerDom, routerRedux, reduxDevTools)
285-
286261
lazy val exampleStyle = project.in(file("example") / "style")
287262
.settings(exampleCommonSettings: _*)
288263
.settings(
@@ -332,7 +307,6 @@ lazy val exampleTest = project.in(file("example") / "test")
332307
s"-Dtarget.path.redux-devtools=${(crossTarget in exampleReduxDevTools).value}",
333308
s"-Dtarget.path.redux-middleware=${(crossTarget in exampleReduxMiddleware).value}",
334309
s"-Dtarget.path.router=${(crossTarget in exampleRouter).value}",
335-
s"-Dtarget.path.router-redux=${(crossTarget in exampleRouterRedux).value}",
336310
s"-Dtarget.path.style=${(crossTarget in exampleStyle).value}",
337311
s"-Dtarget.path.todo-app=${(crossTarget in exampleTodoApp).value}",
338312
s"-Dtarget.path.todo-app-redux=${(crossTarget in exampleTodoAppRedux).value}"
@@ -346,7 +320,6 @@ lazy val exampleTest = project.in(file("example") / "test")
346320
webpack in fastOptJS in Compile in exampleReduxDevTools,
347321
webpack in fastOptJS in Compile in exampleReduxMiddleware,
348322
webpack in fastOptJS in Compile in exampleRouter,
349-
webpack in fastOptJS in Compile in exampleRouterRedux,
350323
webpack in fastOptJS in Compile in exampleStyle,
351324
webpack in fastOptJS in Compile in exampleTodoApp,
352325
webpack in fastOptJS in Compile in exampleTodoAppRedux

example/README.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -157,5 +157,4 @@ Sure, you can! All the projects in this folder are fully working examples, but h
157157
- [Router](/example/routing/src/main/scala/io/github/shogowada/scalajs/reactjs/example/router/Main.scala)
158158
- [Redux](/example/todo-app-redux/src/main/scala/io/github/shogowada/scalajs/reactjs/example/todoappredux)
159159
- [Redux Middleware](/example/redux-middleware/src/main/scala/io/github/shogowada/scalajs/reactjs/example/redux/middleware/Main.scala)
160-
- [Router Redux](/example/router-redux/src/main/scala/io/github/shogowada/scalajs/reactjs/example/router/redux/Main.scala)
161160
- [Redux DevTools](/example/redux-devtools/src/main/scala/io/github/shogowada/scalajs/reactjs/example/redux/devtools/Main.scala)

example/router-redux/src/main/scala/io/github/shogowada/scalajs/reactjs/example/router/redux/Main.scala

Lines changed: 0 additions & 215 deletions
This file was deleted.

example/router-redux/src/main/webapp/index.html

Lines changed: 0 additions & 6 deletions
This file was deleted.

example/test/src/it/scala/io/github/shogowada/scalajs/reactjs/example/TestTargetServer.scala

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,6 @@ object TestTargetServers {
5757
lazy val reduxDevTools = init(new TestTargetServer("redux-devtools"))
5858
lazy val reduxMiddleware = init(new TestTargetServer("redux-middleware"))
5959
lazy val router = init(new TestTargetServer("router"))
60-
lazy val routerRedux = init(new TestTargetServer("router-redux"))
6160
lazy val style = init(new TestTargetServer("style"))
6261
lazy val todoApp = init(new TestTargetServer("todo-app"))
6362
lazy val todoAppRedux = init(new TestTargetServer("todo-app-redux"))

0 commit comments

Comments
 (0)