From 2cd691161ebfc3b4fa11674a9b86a7d7a73b9015 Mon Sep 17 00:00:00 2001 From: Siteshwar Vashisht Date: Tue, 18 Feb 2025 17:29:05 +0100 Subject: [PATCH 1/2] fix(lvm): improve completions for `lvremove` It should have a completion for `/dev/mapper` path. Signed-off-by: Siteshwar Vashisht --- completions/lvm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/completions/lvm b/completions/lvm index 70581a7fc9e..6bdd36452ed 100644 --- a/completions/lvm +++ b/completions/lvm @@ -26,7 +26,7 @@ _comp_cmd_lvm__physicalvolumes() _comp_cmd_lvm__logicalvolumes() { _comp_compgen_split -- "$(lvscan 2>/dev/null | - command sed -n -e "s|^.*'\(.*\)'.*$|\1|p")" + command sed -n -e "s|^.*'\(.*\)'.*$|\1|p") /dev/mapper/" if [[ $cur == /dev/mapper/* ]]; then _comp_compgen -a filedir local i From e4bac86ca0fd1157fc96ff1d70755aae38cda9c1 Mon Sep 17 00:00:00 2001 From: Koichi Murase Date: Mon, 3 Mar 2025 22:18:58 +0900 Subject: [PATCH 2/2] test(lvremove): test generation of "/dev/mapper/" --- test/t/test_lvremove.py | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/test/t/test_lvremove.py b/test/t/test_lvremove.py index 17486aa03bc..1a62b5348b7 100644 --- a/test/t/test_lvremove.py +++ b/test/t/test_lvremove.py @@ -7,3 +7,7 @@ class TestLvremove: ) def test_1(self, completion): assert completion + + @pytest.mark.complete("lvremove /dev/map") + def test_2(self, completion): + assert completion == "per/"