From 2588308d4040a0cbf3c5a3f813c2326ccf7610b6 Mon Sep 17 00:00:00 2001 From: Christian Kujau Date: Thu, 18 Jul 2019 01:52:12 -0700 Subject: [PATCH] Link against libcrypto on Linux systems. This would fix https://github.com/signalapp/Signal-Desktop/issues/2634 ("Signal v1.15.0 and newer crash on startup on Fedora Linux 28/29 (and others), libcrypto related during DB operations (induced by sqlcipher binaries)"), maybe? --- deps/sqlite3.gyp | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/deps/sqlite3.gyp b/deps/sqlite3.gyp index 059ea3cf..5596b5b6 100755 --- a/deps/sqlite3.gyp +++ b/deps/sqlite3.gyp @@ -72,8 +72,7 @@ { # Linux 'link_settings': { 'libraries': [ - # This statically links libcrypto, whereas -lcrypto would dynamically link it - '<(SHARED_INTERMEDIATE_DIR)/sqlcipher-amalgamation-<@(sqlite_version)/OpenSSL-Linux/libcrypto.a' + '-lcrypto' ] } }] @@ -138,10 +137,9 @@ '<(SHARED_INTERMEDIATE_DIR)/sqlcipher-amalgamation-<@(sqlite_version)/openssl-include/' ] }, - { # linux + { # Linux 'include_dirs': [ '<(SHARED_INTERMEDIATE_DIR)/sqlcipher-amalgamation-<@(sqlite_version)/', - '<(SHARED_INTERMEDIATE_DIR)/sqlcipher-amalgamation-<@(sqlite_version)/openssl-include/' ] }] ],