better handling of invalid message sources

Goober5000 · Goober5000 · commit 43f8b123a8db · 2022-06-25T15:56:52.000-04:00
Another bug discovered by Durandal.  The message sender was a variable containing an invalid value, and the game crashed.  This handles it more gracefully.

Tested and verified.
diff --git a/code/parse/sexp.cpp b/code/parse/sexp.cpp
@@ -13353,7 +13353,8 @@ void sexp_send_one_message( const char *name, const char *who_from, const char *
 	} else if ( !stricmp(who_from, "<none>") ) {
 		source = MESSAGE_SOURCE_NONE;
 	} else {
-		Assertion(false, "Curious... all message sources should have been covered");
+		Warning(LOCATION, "Invalid message source '%s'.  Unable to send message.", who_from);
+		return;
 	}
 
 	if ( ship_index == -1 ){

Original file line number	Diff line number	Diff line change
`@@ -13353,7 +13353,8 @@ void sexp_send_one_message( const char name, const char who_from, const char *`
`13353`	`13353`	`} else if ( !stricmp(who_from, "<none>") ) {`
`13354`	`13354`	`source = MESSAGE_SOURCE_NONE;`
`13355`	`13355`	`} else {`
`13356`		`- Assertion(false, "Curious... all message sources should have been covered");`
	`13356`	`+ Warning(LOCATION, "Invalid message source '%s'. Unable to send message.", who_from);`
	`13357`	`+ return;`
`13357`	`13358`	`}`
`13358`	`13359`
`13359`	`13360`	`if ( ship_index == -1 ){`