Skip to content

Commit 50b2d7d

Browse files
expound on play-sound-from-file TODO note
1 parent 92cc8bb commit 50b2d7d

File tree

1 file changed

+6
-1
lines changed

1 file changed

+6
-1
lines changed

code/parse/sexp.cpp

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14364,7 +14364,12 @@ void sexp_play_sound_from_file(int n)
1436414364
int type = ASF_MENUMUSIC;
1436514365
if (n >= 0)
1436614366
{
14367-
// TODO: SDL3 => make this work with ds_play somehow to get EFX
14367+
// TODO: SDL3 => Having AudioStream::WriteWaveData() pipe the data through
14368+
// new ds functions would be the cleanest way to replicate
14369+
// this but it may not be worth the effort considering EFX
14370+
// is disabled by default and most players probably don't
14371+
// bother enabling it. This really wasn't a well thought out
14372+
// feature in the first place and should maybe be dropped.
1436814373

1436914374
if (eval_sexp(n) != 0)
1437014375
type = ASF_SOUNDFX;

0 commit comments

Comments
 (0)