fix crash in hud_get_custom_gauge()

Goober5000 · Goober5000 · commit 98de7323aa92 · 2024-09-11T01:31:22.000-04:00
The `Player_ship` variable can sometimes be NULL, especially in FRED, so revise the conditional to check for this.
diff --git a/code/hud/hud.cpp b/code/hud/hud.cpp
@@ -3908,7 +3908,9 @@ void hud_page_in()
 
 HudGauge* hud_get_custom_gauge(const char* name, bool check_all_gauges)
 {
-	auto player_sip = Player_ship->ship_info_index < 0 ? nullptr : &Ship_info[Player_ship->ship_info_index];
+	ship_info *player_sip = nullptr;
+	if (Player_ship && Player_ship->ship_info_index >= 0)
+		player_sip = &Ship_info[Player_ship->ship_info_index];
 
 	// go through all gauges for all ships and defaults
 	if (check_all_gauges) {

Original file line number	Diff line number	Diff line change
`@@ -3908,7 +3908,9 @@ void hud_page_in()`
`3908`	`3908`
`3909`	`3909`	`HudGauge* hud_get_custom_gauge(const char* name, bool check_all_gauges)`
`3910`	`3910`	`{`
`3911`		`- auto player_sip = Player_ship->ship_info_index < 0 ? nullptr : &Ship_info[Player_ship->ship_info_index];`
	`3911`	`+ ship_info *player_sip = nullptr;`
	`3912`	`+ if (Player_ship && Player_ship->ship_info_index >= 0)`
	`3913`	`+ player_sip = &Ship_info[Player_ship->ship_info_index];`
`3912`	`3914`
`3913`	`3915`	`// go through all gauges for all ships and defaults`
`3914`	`3916`	`if (check_all_gauges) {`